Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] Input: sur40: Improve a size determination in
 sur40_probe()
To:     SF Markus Elfring <elfring@users.sourceforge.net>,
        linux-input@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Florian Echtler <floe@butterbrot.org>,
        Johan Hovold <johan@kernel.org>,
        Martin Kaltenbrunner <modin@yuri.at>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <a7e25da3-587a-f0e8-d574-8066b340d9a6@users.sourceforge.net>
 <11e0b313-f8c2-93ec-0324-24b30053a586@users.sourceforge.net>
From:   Martin Kepplinger <martink@posteo.de>
Message-ID: <8b3fb313-b69d-f381-dde8-212a85b5a90e@posteo.de>
Date:   Mon, 22 Jan 2018 08:02:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <11e0b313-f8c2-93ec-0324-24b30053a586@users.sourceforge.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018-01-20 22:30, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 20 Jan 2018 22:16:14 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Martin Kepplinger <martink@posteo.de>

> ---
>  drivers/input/touchscreen/sur40.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index c7a0a92b2044..946e1a0328b4 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -550,7 +550,7 @@ static int sur40_probe(struct usb_interface *interface,
>  		return -ENODEV;
>  
>  	/* Allocate memory for our device state and initialize it. */
> -	sur40 = kzalloc(sizeof(struct sur40_state), GFP_KERNEL);
> +	sur40 = kzalloc(sizeof(*sur40), GFP_KERNEL);
>  	if (!sur40)
>  		return -ENOMEM;
>  
>