Received: by 10.223.176.46 with SMTP id f43csp2693560wra; Mon, 22 Jan 2018 01:43:56 -0800 (PST) X-Google-Smtp-Source: AH8x227HQ4su3LXpR9yUIrdzg+GolwUAYSrdwHH4JmcAOEHEp2QJWPWyyMWIj0gyNeo3EeE1hPcD X-Received: by 10.99.107.73 with SMTP id g70mr6920880pgc.281.1516614236833; Mon, 22 Jan 2018 01:43:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516614236; cv=none; d=google.com; s=arc-20160816; b=UJubJHTBOj/pB1N0guk83vm/cl4s/QfjDS6tVNFQZIBM3Mr0pw0kN6vJ5r5V++JCJ5 LbAsWUQsrjLMBP9i/KSOVyZtmzg0342MeV49NU2JRtQb4Ylwgpqq3itvJYwTJ24/puAr xjL2t4jdQdrDBGGLSUTSBBZtzPXR1jAEaD9nlQciUYxzJ82v8fRN6wUXQqi5ryMnup7b mA8gLQBUPJRkx+nYy80w7ARmwZ5CaGolmR822xZh2e9NXXXJSSGP5bke+Oyiq/mn1zkA pytxOS+eUwTFhk1g8362KKuALA8o1fOQLrX5lE+DAV1B3hOSxgD5x7Y+e7kE03xMMZXU X8JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=NGNsONkL8JEUGlf7almKsaTKNqmmrfRUAIQbjD8K3Y0=; b=O5JTu5ai4vpklPyVW+GC1cOC9mF/F2zC0R4ytQCGh+VUvDLzV07G0s2lrLx5WaGoOA 6aTfW6UqEDwcQlV1CrgNK7VAtBM4leS0iEEO59TGYBtpeLUISjhokN8WE3wffzXC6plp L6Lv9yQ7AzAX2B8n7HhNWgRL6By4ENtUbSz9MuSgg0JfGrfcF31+pMQWByjFHjUI/ay+ z+iU3v5/sW1E0UqCQkYOn+nBlK+nBbn8NAIDbG+bPUDt3EuEv5PDc/Wn3tACdBA9pq1k cN+OX2dWEtVfnhNQp46ei+2HlKZSU9z6SRrWFpRm4AVs9rkTQSfBzCBiimx+9S3Ah2Vr VfLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y63si13580576pgd.540.2018.01.22.01.43.42; Mon, 22 Jan 2018 01:43:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbeAVJms (ORCPT + 99 others); Mon, 22 Jan 2018 04:42:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58808 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbeAVImK (ORCPT ); Mon, 22 Jan 2018 03:42:10 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id B27E2F33; Mon, 22 Jan 2018 08:42:09 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masahiro Yamada , Michal Marek , Razvan Ghitulete Subject: [PATCH 4.4 09/53] kconfig.h: use __is_defined() to check if MODULE is defined Date: Mon, 22 Jan 2018 09:40:01 +0100 Message-Id: <20180122083910.690478343@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083910.299610926@linuxfoundation.org> References: <20180122083910.299610926@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Masahiro Yamada commit 4f920843d248946545415c1bf6120942048708ed upstream. The macro MODULE is not a config option, it is a per-file build option. So, config_enabled(MODULE) is not sensible. (There is another case in include/linux/export.h, where config_enabled() is used against a non-config option.) This commit renames some macros in include/linux/kconfig.h for the use for non-config macros and replaces config_enabled(MODULE) with __is_defined(MODULE). I am keeping config_enabled() because it is still referenced from some places, but I expect it would be deprecated in the future. Signed-off-by: Masahiro Yamada Signed-off-by: Michal Marek Signed-off-by: Razvan Ghitulete Signed-off-by: Greg Kroah-Hartman --- include/linux/kconfig.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) --- a/include/linux/kconfig.h +++ b/include/linux/kconfig.h @@ -17,10 +17,11 @@ * the last step cherry picks the 2nd arg, we get a zero. */ #define __ARG_PLACEHOLDER_1 0, -#define config_enabled(cfg) _config_enabled(cfg) -#define _config_enabled(value) __config_enabled(__ARG_PLACEHOLDER_##value) -#define __config_enabled(arg1_or_junk) ___config_enabled(arg1_or_junk 1, 0) -#define ___config_enabled(__ignored, val, ...) val +#define config_enabled(cfg) ___is_defined(cfg) +#define __is_defined(x) ___is_defined(x) +#define ___is_defined(val) ____is_defined(__ARG_PLACEHOLDER_##val) +#define ____is_defined(arg1_or_junk) __take_second_arg(arg1_or_junk 1, 0) +#define __take_second_arg(__ignored, val, ...) val /* * IS_BUILTIN(CONFIG_FOO) evaluates to 1 if CONFIG_FOO is set to 'y', 0 @@ -42,7 +43,7 @@ * built-in code when CONFIG_FOO is set to 'm'. */ #define IS_REACHABLE(option) (config_enabled(option) || \ - (config_enabled(option##_MODULE) && config_enabled(MODULE))) + (config_enabled(option##_MODULE) && __is_defined(MODULE))) /* * IS_ENABLED(CONFIG_FOO) evaluates to 1 if CONFIG_FOO is set to 'y' or 'm',