Received: by 10.223.176.46 with SMTP id f43csp2738628wra; Mon, 22 Jan 2018 02:35:19 -0800 (PST) X-Google-Smtp-Source: AH8x2246yrARGUqkqe6/wwE7pI9RTRmNiOev57/yZrn8iO/qTi+LUDo+Z68/ixzTK5x6XMklAzLF X-Received: by 2002:a17:902:6bc4:: with SMTP id m4-v6mr3302776plt.118.1516617319397; Mon, 22 Jan 2018 02:35:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516617319; cv=none; d=google.com; s=arc-20160816; b=JgIJLy5Nu0qqYjnnGpVPX1EaxFkW8FlxHYzbjd4d1NI30RMQGWNeWTK+b4zuRriDRz MLwSrsowH60hsV7mZu7yN8GuTXPob8avI6JleTlHYoKE2SW5RSk/Ln4faqHt26BvcBNp tNPd9vDbp7he2v6O2d1L+KolSPIO5oCF/i5Gormfb7afJ5CDoA/oFTUfWTy6+xqW8430 oXX3JwhFFQxKi60/MootgFc2p71bBVDrpc6MDNwVb4KqS/vJqsrZWRFfdJ0RcIvL/04s 9vF2Q/9JRUvYg7raFF2KWXQebd6ojaNfzhYGBAk/yo4isiiDgm0yk8xCJQdvkg9GF9tC 8awQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=ApShUxsQA/B0jhd2fM5ZTGj94oVHzf1/XzPQqdBtDtI=; b=WquLPdqu22dyzCXU01f6TkfNMsV3GgLDqHYheGXUA2D/lw5DqHzAALTm8nWE8nWFuX +Ns+b4kAJZLksZXwuXKixlwV0xZbKT/ZTiahhM/cVnDUgj+uulotvN4727rfz1LJTU8P CB5Ok6wHQKJcaDPf1qu3CxhKaa0EmxNJmS78pEuaZYrkwIhFVU9sW7Lmc6st4J0ZJjxl GFnlb0D7/RyUiaLmrMPiNOR8//P6Ym+4Ub85Sutf6LZcndTeADY8J4m44Ky/M68hWGla C0YIyqiV0Q9W6PBokWfsWb9Dwi0q0SwhkrDjbYFrWD1k3ccAzt+Ihr66yAqbye0ckNt9 yGqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si13631195pgq.466.2018.01.22.02.35.05; Mon, 22 Jan 2018 02:35:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751166AbeAVKed (ORCPT + 99 others); Mon, 22 Jan 2018 05:34:33 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:15898 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbeAVKea (ORCPT ); Mon, 22 Jan 2018 05:34:30 -0500 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w0MATYaq024970; Mon, 22 Jan 2018 11:34:12 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2fnauws4c8-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 22 Jan 2018 11:34:12 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F31A434; Mon, 22 Jan 2018 10:34:10 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas23.st.com [10.75.90.46]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id AB2662600; Mon, 22 Jan 2018 10:34:10 +0000 (GMT) Received: from SAFEX1HUBCAS24.st.com (10.75.90.95) by SAFEX1HUBCAS23.st.com (10.75.90.46) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 22 Jan 2018 11:34:10 +0100 Received: from localhost (10.201.23.32) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 22 Jan 2018 11:34:09 +0100 From: Philippe Cornu To: Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Vincent Abriou , David Airlie , , , "Archit Taneja" , Andrzej Hajda , "Laurent Pinchart" CC: Fabien Dessenne , Mickael Reulier , Ludovic Barre , "Alexandre Torgue" , Maxime Coquelin Subject: [PATCH] drm/stm: drv: Improve data transfers Date: Mon, 22 Jan 2018 11:33:35 +0100 Message-ID: <20180122103335.12820-1-philippe.cornu@st.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.32] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-22_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To optimize data transfers, align pitch on 128 bytes & height on 4 bytes. This optimization is not applicable without MMU. Signed-off-by: Yannick Fertre Signed-off-by: Vincent Abriou Signed-off-by: Philippe Cornu --- drivers/gpu/drm/stm/drv.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c index 8fe954c27fba..c2bd9d882b93 100644 --- a/drivers/gpu/drm/stm/drv.c +++ b/drivers/gpu/drm/stm/drv.c @@ -31,6 +31,23 @@ static const struct drm_mode_config_funcs drv_mode_config_funcs = { .atomic_commit = drm_atomic_helper_commit, }; +#ifdef CONFIG_MMU +static int stm_dumb_create(struct drm_file *file, struct drm_device *dev, + struct drm_mode_create_dumb *args) +{ + unsigned int min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8); + + /* + * in order to optimize data transfer, pitch is aligned on + * 128 bytes, height is aligned on 4 bytes + */ + args->pitch = roundup(min_pitch, 128); + args->height = roundup(args->height, 4); + + return drm_gem_cma_dumb_create_internal(file, dev, args); +} +#endif + DEFINE_DRM_GEM_CMA_FOPS(drv_driver_fops); static struct drm_driver drv_driver = { @@ -44,7 +61,11 @@ static struct drm_driver drv_driver = { .minor = 0, .patchlevel = 0, .fops = &drv_driver_fops, +#ifdef CONFIG_MMU + .dumb_create = stm_dumb_create, +#else .dumb_create = drm_gem_cma_dumb_create, +#endif .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle, .gem_free_object_unlocked = drm_gem_cma_free_object, -- 2.15.1