Received: by 10.223.176.46 with SMTP id f43csp2774892wra; Mon, 22 Jan 2018 03:13:52 -0800 (PST) X-Google-Smtp-Source: AH8x224SPrC2W37PkxjCS3o6EvCE+ordx/f6mNI/ZD7+S7pEPYksU0pujdBBH/MbNkS9f3F/ktDp X-Received: by 10.101.69.141 with SMTP id o13mr7138277pgq.204.1516619631966; Mon, 22 Jan 2018 03:13:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516619631; cv=none; d=google.com; s=arc-20160816; b=xPvlUc1oCQB9my7zLLVinHwDVQWebDAY8bRzVNHzrmOf1MUsz/jrpDfe11eY42k3ZA +Vac0SQW0jrURYVTaccjPtqG5KdI+F3dWtMPeAIVmf4fRS/mDHAOudUrQ2+lAbbsM0ZF 6HDXmKfTAPfOn2hW7eGmMO/SqcznqNWmKmEmiTTYkmW05AjjpShm6Yzc+pg7i+oQX5zX rwh3ncqSsb2LQuxuTH5LmRb0HP8cuZhLRA+e4wJUrM8NqVVL9gViJBPY/a/8ykUmawVI qRgq49imaHnJmdLicIEVwoN4Klo9Q86NzkV8E5UEFAiId5Vv+rSAXY3Fd80WtvZ8JHbE Dkgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:to:subject:cc :arc-authentication-results; bh=AfD5hx0EG679H1fpz7HR1ziTdzhMPLPTwnAirUCH2no=; b=RzkICIZTazS+6AfieGB/carlGC986U6+YDrA5PmPVrdSpDZLFDC7DzA4MYmkt3d2ds F8fAz3kkhmh6eTCHyotFpTAFmimr1VaJAm3GfUpokToHZ5HSe+ZxINln4/51JYcHrF0n 1Ge4NicGmKkpa+U/P6Tov5CYDt1ZFgFSRhU2I3M2StT+xEdDoRkd78/YeCmo3/UBw/Yr 21sG8Ei7S9KFsw+P3lEGeWYWbYIntelHOrLaYj/w6UImWymG0LQiyMGTJ+zldI55+TJg e9vbL3ym+g3yLCrjxqc2VWicJxGhe/2ESN4DjbvnS4WxfM9THblBmQUEQ5GM2PJdTpuV wpvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h15-v6si3304658plk.480.2018.01.22.03.13.37; Mon, 22 Jan 2018 03:13:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbeAVLNL (ORCPT + 99 others); Mon, 22 Jan 2018 06:13:11 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:57240 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbeAVLNK (ORCPT ); Mon, 22 Jan 2018 06:13:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 89C701529; Mon, 22 Jan 2018 03:13:09 -0800 (PST) Received: from [10.1.210.28] (e107155-lin.cambridge.arm.com [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C2B63F53D; Mon, 22 Jan 2018 03:13:07 -0800 (PST) Cc: Sudeep Holla , devicetree , Linux Kernel list , Loys Ollivier , Bjorn Andersson , Rob Herring , Frank Rowand Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak To: Andy Gross References: <1516272219-25359-1-git-send-email-sudeep.holla@arm.com> From: Sudeep Holla Organization: ARM Message-ID: <10e5ef22-37e5-986f-eda0-446214c5626b@arm.com> Date: Mon, 22 Jan 2018 11:13:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/01/18 23:34, Andy Gross wrote: > On 19 January 2018 at 09:37, Sudeep Holla wrote: >> Hi Andy, >> >> On 18/01/18 10:43, Sudeep Holla wrote: >>> We need to call of_node_put() for device nodes obtained with >>> of_find_node_by_path(). >>> >>> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()") >>> Reported-by: Loys Ollivier >>> Cc: Rob Herring >>> Cc: Frank Rowand >>> Signed-off-by: Sudeep Holla >>> --- >>> drivers/of/platform.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >> >> Can you pick up this with other fixes you would send after v4.16-rc1 or >> do you prefer me to route through ARM-SoC directly ? Let me know. > > I can pick this up for fixes, no problem. I can send it along right > now if you like. This is a pretty low risk patch. > Thanks Andy. -- Regards, Sudeep