Received: by 10.223.176.46 with SMTP id f43csp2999656wra; Mon, 22 Jan 2018 06:55:54 -0800 (PST) X-Google-Smtp-Source: AH8x227G1RxH11Jamo0mBWkKuQcxeVIc4rwWB4qF9iStEsaaw+KlI+D7lonTtiLy1UF4rbQotqNB X-Received: by 10.36.69.219 with SMTP id c88mr8704734itd.68.1516632954432; Mon, 22 Jan 2018 06:55:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516632954; cv=none; d=google.com; s=arc-20160816; b=FfdUZ+8MN/PHGOrgilNpyBpSO1XhkIO6W39AFNAAg/+LPEsciKN+VQVT4wpWLPEOxb Ct/P+aBoB1idvddWkw5FEMH9DFFR0JL2gEPogEBc0xBvpzJ+9Bn/1WVfCkFcPfKhiVU0 njTmUzRgTig7tcc6DP/BnJpH1CZsYYNUhNECdeUz/Bom762XL/7iQGcMjCs6SrdEXTsC tWhRS5mdD2F8gg1esNih+rY+/fWmj0r1GRRgg3+zvLjU3uwWeFBPbrL9Cef9WItE2ea0 EhsRSfROQeRdXavqa5gKod7ixfSmq4N45n/uxFfDyUMJ8bcOzNKMo2lFFZ74aPPAHUVz MBWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature:arc-authentication-results; bh=Pe5AUsiA7M/EJyzJQXbEfIuTI27QsA37wucShldDHSQ=; b=QpwOdYmJ1Fb4F08VSWgh3XEV/CGBzM5kDj1aYIN1ItOFQGHKQ8SmBGF5+n8QxSQcde 7vLPmYOuSNvls7HqnyHWid0appcMpH2/lFSaqxWDoAaAaLiblfpnOeWRvWlJsiOtC92P HaIh/VJpEpeJFb362hiHF0z1eYgHY3XIvWbWUS2oGamyfPO/0byT9EHQoWOHBPHtSCkw ecvl8YHlf4JtS2gLtmf8uumACgVIB2psSFsfmcBzNdH0Y8plaiq8kfwVnjXxIfmHpQsE q8i0wQcxOu3mIka5V83bIUq4tn6JOz2mYlP5xIzR6biXc9aRMKS4qSiXu2irUBkvZbta 7hBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IBNX89yR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e25si13523103ioj.278.2018.01.22.06.55.40; Mon, 22 Jan 2018 06:55:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IBNX89yR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751311AbeAVOyw (ORCPT + 99 others); Mon, 22 Jan 2018 09:54:52 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:42589 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbeAVOyv (ORCPT ); Mon, 22 Jan 2018 09:54:51 -0500 Received: by mail-pg0-f65.google.com with SMTP id q67so7261763pga.9 for ; Mon, 22 Jan 2018 06:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Pe5AUsiA7M/EJyzJQXbEfIuTI27QsA37wucShldDHSQ=; b=IBNX89yR4sma2RV5w/tNs3Ms2Bfw7ISv1DAZOInRRSZo3tyRKhniIS37IKUG9bv374 IADTvRJL7wpLKSfdRP52YxTgseTWWcF2rsSMjXkkutdsWiywFlQVayav/QhTWGZLOuHb qqT6zc5CMVcwlloSU5X8biDVkoe2LRfvkgOra8LrwY01zwWzoU29D4dmfhuLvx5pww9Z OBLJRpD/ElWMyaFkSYtI226CcZTEfoS14OATecbxsDg81eFi5A6iydMReOvJ7ScxMQa1 4U7QdxKTQ4KJozwu6qQ3szdHJTTLHvBS4GXWAGHhY70ezmpJEq6n6yiBdCthNLT0BbVE V/0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Pe5AUsiA7M/EJyzJQXbEfIuTI27QsA37wucShldDHSQ=; b=Z7os9bEcY0TaV2Peio33pT8pqyMNN7Bw8ef9YOeQugJEOYEQPsWwgPjkYNOUAy0hJy smh4YuzWJEQ7/ID+lJfMvnY7tqTqnTovlIXo0s48v49kzfRsPcYQVDlM41YZgsj39uoO 0A+AGQCDBqSN8KFXfgaXQcbFCLrh1j9Rx5FbZGlstGm7YbhvNEfRmjwb2IpuQqwtW4jk rTfkCozoJJWeWh0Tdf8+2w3ui1+nWrOcdYv/g1R9lRnecIIXdhL92fTLVRVxLUOo9YkZ Wq/ilqTSBGKdNBySxa3x0vjOU57F3bzZAsQUMV2B/hcDxuRxsHEvU4+y9DkLj3EuP1HM AH9A== X-Gm-Message-State: AKwxytcnPrsG7EAtlnjNnA7e1NfcCIDTQ+8bQbPW+Hss/7Ve8sghBmXV c4AVI+f2B/3dHkXC5IM8a4k= X-Received: by 10.98.78.148 with SMTP id c142mr8636667pfb.153.1516632890586; Mon, 22 Jan 2018 06:54:50 -0800 (PST) Received: from raspberrypi ([122.171.92.137]) by smtp.gmail.com with ESMTPSA id f5sm27447454pgn.13.2018.01.22.06.54.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 06:54:49 -0800 (PST) Date: Mon, 22 Jan 2018 14:54:44 +0000 From: Meghana Madhyastha To: Lee Jones , Daniel Thompson , Jingoo Han , Thierry Reding , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v18 08/10] drm/omapdrm: Use backlight_enable/disable helpers Message-ID: <30d5b26c3c7d75de3d2ab3cff9dee67084fc3caf.1516632388.git.meghana.madhyastha@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index e065f7e10..ac9596251 100644 --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c @@ -87,11 +87,7 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev) } gpiod_set_value_cansleep(ddata->enable_gpio, 1); - - if (ddata->backlight) { - ddata->backlight->props.power = FB_BLANK_UNBLANK; - backlight_update_status(ddata->backlight); - } + backlight_enable(ddata->backlight); dssdev->state = OMAP_DSS_DISPLAY_ACTIVE; @@ -106,10 +102,7 @@ static void panel_dpi_disable(struct omap_dss_device *dssdev) if (!omapdss_device_is_enabled(dssdev)) return; - if (ddata->backlight) { - ddata->backlight->props.power = FB_BLANK_POWERDOWN; - backlight_update_status(ddata->backlight); - } + backlight_disable(ddata->backlight); gpiod_set_value_cansleep(ddata->enable_gpio, 0); regulator_disable(ddata->vcc_supply); -- 2.11.0