Received: by 10.223.176.46 with SMTP id f43csp3063290wra; Mon, 22 Jan 2018 07:52:05 -0800 (PST) X-Google-Smtp-Source: AH8x2272VExdSlRFiTfyZtOCVgKj5xDx359hhtxDG8EdHlsL3M/raX13xX5C1GPBZrrYY1nb0DKo X-Received: by 10.107.70.4 with SMTP id t4mr624362ioa.234.1516636325622; Mon, 22 Jan 2018 07:52:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516636325; cv=none; d=google.com; s=arc-20160816; b=Uke8/cH3d6mxCAjDylfIqRbwgwyM55duUNLr+PN8Vy/6AO4Uev8G6xe7x3qE4oCUl5 e4lrzxePaSfdIrEXIYig+DW6Gdqn9PLIWKaRVpvSHNtXf30iI2ZOjdUPJ0Ri+6IxWTNE ujBcEY/hdrU8S5aKalCGXgRpc2f3LjJzbkfPikOrKnMMI5IBniUDsOpJr42j4n7yJei5 ANv4wDdXx2SKfOHTGLlB4QJ8Bjt4sVgFJ8db/ODMifmbgis/S+QraNhV/psKuE6Iake1 TaNQWg+aHlpfCht/kfWvXLnuEkRq1CLVfw+q6fVYsWbBqctneRB1Pm7Eg9nRsa0YZG2v +6jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=nisf789dsyzxAS3n2SuWHbR+POOOp66rLaqSZMT7Lbc=; b=L/oOyZ2zL8v1fAMEq3cxcu8USpWOVisYXQGjSdohvmReMH6F7dfxPp0qHtyr/N6g/8 KhhYEnCda7lw74T+wBCxtAYh4BNnFuQTlBn30ZGk3z2ZJCj+zSUh2K8S9dpgJd/4jEkG xxPykEPDJ24U9+Y1Y80goLWivrwCqn4O+aBDgdJia7jn8C6Z2NQlJQ81pMzUiftlNza8 rHghpTH2/cH6zZY1n2/Je13ZnWdQycI/4lyukEWNmA5bEA/vHFrUEC1VV93dgEJUxosd aHhKZ445hjomd+hvStxyLjGny8uieWY1ckW6B2AvNNchFKE1dlJHj7hjyW6QiL7FOOI3 VPZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RNob4K6j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e67si5999000itc.98.2018.01.22.07.51.52; Mon, 22 Jan 2018 07:52:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RNob4K6j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751167AbeAVPvE (ORCPT + 99 others); Mon, 22 Jan 2018 10:51:04 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38111 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbeAVPvB (ORCPT ); Mon, 22 Jan 2018 10:51:01 -0500 Received: by mail-wr0-f193.google.com with SMTP id x1so9178423wrb.5 for ; Mon, 22 Jan 2018 07:51:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nisf789dsyzxAS3n2SuWHbR+POOOp66rLaqSZMT7Lbc=; b=RNob4K6jxYURM0kNjUUQkvKY4X2mWxT0KIoGbm52Wr4E0Ywzu0prVXWyLvD9hHfsVo dFw/jmUnchCRbQyfc+FVImjIwwBwin8osNKK9LXM32ZORx6OOfIksgkaoSDodby0yBrn 2GXFwkJ6MTuLAZ0lsFUH/RRs9pB87WeLIegaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nisf789dsyzxAS3n2SuWHbR+POOOp66rLaqSZMT7Lbc=; b=sUkKyfj6h3a91EIapldly8PpSYxnPeIq9QObmab0wO5UoPTDRoeG0m8DhABHUYaVow wGFnT+RKRgCYMHjex6se9UfIdeQlE811Mq1LJ0M/sUOB7joxIBuZdHlmQ2dcBCDIZjBP xDTafhfXtVUrNX7xwpuK+GfCd0W28xXsiQNJQehA41se5Z6jOq1Fyy7PSQKWo2apaJRf LLGLAk+bbTaCc2mlDX2nx9gdVc4c1bhWDCNQl1H+H0fw7MOFtkrcOgFnJWvRlf4jZHcV V1IbbpWIJmUhBZB2n9BPrV+Su+ai1WxQUYPbvL1v+LeeaDsClclXsEPcqG2ZbapAnkQK L7+Q== X-Gm-Message-State: AKwxytcWknWMlbDACFT9Y7rJxN+wUq529Df+yBSt7YDz7cHHRaGBuTTv g2XXWjSexz1KNoK/dFyyD9M3rA== X-Received: by 10.223.183.43 with SMTP id l43mr7375693wre.181.1516636260666; Mon, 22 Jan 2018 07:51:00 -0800 (PST) Received: from dell ([2.27.167.60]) by smtp.gmail.com with ESMTPSA id i47sm23421734wrf.26.2018.01.22.07.50.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 07:50:59 -0800 (PST) Date: Mon, 22 Jan 2018 15:50:57 +0000 From: Lee Jones To: SF Markus Elfring Cc: linux-omap@vger.kernel.org, Tony Lindgren , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] mfd/omap-usb-tll: Return an error code only as a constant in usbtll_omap_probe() Message-ID: <20180122155057.7eiu53l6xjls6uga@dell> References: <367e77d8-3a65-2c12-5e79-75a626b65f41@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <367e77d8-3a65-2c12-5e79-75a626b65f41@users.sourceforge.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Jan 2018, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 15 Jan 2018 14:00:45 +0100 > > * Return an error code without storing it in an intermediate variable. > > * Delete the label "err_clk_alloc" and local variable "ret" > which became unnecessary with this refactoring. > > Signed-off-by: Markus Elfring > --- > drivers/mfd/omap-usb-tll.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) Applied, thanks. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog