Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 15A7A60328
Date:   Mon, 22 Jan 2018 08:52:57 -0800 (PST)
From:   Liam Mark <lmark@codeaurora.org>
To:     Greg KH <gregkh@linuxfoundation.org>
cc:     Laura Abbott <labbott@redhat.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linaro-mm-sig@lists.linaro.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: ion: Zero CMA allocated memory
In-Reply-To: <20180120080008.GA20172@kroah.com>
Message-ID: <alpine.DEB.2.02.1801220849280.31529@lmark-linux.qualcomm.com>
References: <alpine.DEB.2.02.1801191111200.18415@lmark-linux.qualcomm.com> <20180120080008.GA20172@kroah.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 20 Jan 2018, Greg KH wrote:

> On Fri, Jan 19, 2018 at 11:16:47AM -0800, Liam Mark wrote:
> > Since the CMA API is now used directly the allocated memory is no longer
> > automatically zeroed.
> > 
> > Explicitly zero CMA allocated memory to ensure that no data is exposed
> > to userspace.
> 
> How far back does this patch need to be ported?  What is the git commit
> id that caused this change to be needed?  Please add it as a "Fixes:"
> tag to the patch.
> 

It goes back to 204f672255c2 ("ion: Use CMA APIs directly"), I will update 
the change.

> > 
> > Change-Id: I08e143707a0d31610821a7f16826c262bf3c1999
> 
> I'm guessing you didn't run scripts/checkpatch.pl on this patch :(
> 
> Please fix up and resend.

Thanks, I will clean it up.

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project