Received: by 10.223.176.46 with SMTP id f43csp3216789wra; Mon, 22 Jan 2018 10:13:24 -0800 (PST) X-Google-Smtp-Source: AH8x226u8DZBnYA4l4NhYpaTILxDOnx+Fd+1bQGlcB9x7BkpfgSTx6DMs/AMi5Gp2ovVvelIC0nx X-Received: by 10.36.215.134 with SMTP id y128mr9378904itg.114.1516644804361; Mon, 22 Jan 2018 10:13:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516644804; cv=none; d=google.com; s=arc-20160816; b=SAcwKv1JoQxRCXZ+5mwlmIceCWWFHQuNPicwTHdKWG4Hqkz3D37mD+k43swWgt1dke zvrs4zaOQKjLVGUCZ7pYVKhUooQI0aiZtRCwF3ozwN+EXbnGaZv/afaTYV7e8X6GFJQ4 jxLqco2ejO2rw0uo8vDQHcoWcbxi0BnQKfpgKY3Y8/4p7o7FsydVQAcLReuiWetKg7IE zn6x5Jlr9iRbUlwlpz6LQsnGNaJ1I3BfH3wDIAp1qos5KS60se4KluZFrQ3YomrcLM7i BYt2coJj4H6eL5dJD1AnaG3jN8Arkxn026FS2N8mQUCtAI2kd2aVFrxdT7yvdswY0D5Z H3AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=JaYQJtnD3hQn1f0gIj+ibT/Z+gt7D5cnpqH5odKA/SA=; b=Ue6l5nsBjlSv1/xNs1v4hOJ19iVtyFqATK+Zl6H96oRnEOR/dwgag6/1ucPHP76Adj upBO1lyOfpDJohxIMjwYTajyYFV2FNcIk2Bvf5DvIHiv5ZRxfesNmWRL8P0dFgqJ6oHT 5rWA1TBKOhJPmpF62jvriVgscdAIsYr6h8A9VxIrJDQHWdBed16ExyVATZCX3rNjHwVy 3anEWsgLxX2y5VIn4ou3YNPIh3U3Wh3x1CJUKdb4zy1DcjXV0PRRT+DSzHD5mgjcQfIT 21aLyYzgY4G86uIxJ7EJrymDqP+dKmj04OcTgSJAIrtCiptVhgeYFbxaWtpWHM9LfIp0 K0cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z18si13429742iod.337.2018.01.22.10.13.11; Mon, 22 Jan 2018 10:13:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751215AbeAVSMr (ORCPT + 99 others); Mon, 22 Jan 2018 13:12:47 -0500 Received: from mout.web.de ([212.227.15.3]:54211 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbeAVSMp (ORCPT ); Mon, 22 Jan 2018 13:12:45 -0500 Received: from [192.168.1.2] ([78.49.198.198]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MBkWd-1eTTym20DH-00Apuw; Mon, 22 Jan 2018 19:12:19 +0100 Subject: Re: ARM-SMMU: Delete error messages for a failed memory allocation in three functions To: Robin Murphy , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Cc: =?UTF-8?B?SsO2cmcgUsO2ZGVs?= , Will Deacon , LKML , kernel-janitors@vger.kernel.org References: From: SF Markus Elfring Message-ID: Date: Mon, 22 Jan 2018 19:12:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:SpRG7pXnBbQK1C8TfPMdPqeHOw8Cm+uGByzv5cv5egefk32JXey 0v1gfOLhe6Yv7o8RVntT58U2wlSGoOaUd+O4JeGx2hbfOzaGVZ05bi9cKmYnqznl74OluZS OLPZJlAcsM9T2TtyciGQs46BcS+geSD1uy2wX6hzzDQmPUQlLJra3fZVen1RV67fA4WL09X 7jDMdliWEgS6obFn/Gdlw== X-UI-Out-Filterresults: notjunk:1;V01:K0:SE0hhC9XmRk=:PxyjPb1jhOKqvZ8nLjuJMj rDlBkemfMHBCM7Ds4Q6BuG5B/fh6z99eiugUWgAqLv/2USrZwsd3UfJmRjBDLbg0HEanHF4aT oLbC8GD7mIZsyMFCosearj9Rvd6K9C0c+qnWvE9XxAyFTutw4xty2QghAiJChuS9w5f1yhRnt F1ecschxy2a49cw9W5IEqAghuUPUFDgLDtninK3OkfsAhndHsVtwWFu+Ya6EJ2GsFdanJqwW6 WjANvTHpmKiGaXvrgFaDWwkIoeRvJ2HgK3Svh2gUGvvdu0e34VPTjNcVbHszuZg4UErv/jLfD 7gf9qSWBUllbkMuEivmZ+Anvgx2kILKEqmhrUDCEt4Y3nd7HujoY7tFi3+AFs9h03m6HomzZ4 wsp0emUcJEXRET/E1hvhofQUCwuxS+PstGgb9afAURyCPtWv4D4WDVVhS4Za/CpPeOv7M4CSl pzGk8Im4/V+axLdXIiIGtirK0c2Y+cNdNX4fCxuAgCocv+0NXnGtfCH4qjsOAIXgQxo7PlLuQ Lj05CnJw1o6Iiho6P4f7XDhzLRdV2aXuVL70WkMKDWDlSI6K9wPaaM6fdFWNn2SNz0xME6rex Rw5iBC/vT6wd2byMamFNyoOcLo2uYIEm/qyg9PgBD+hprACIyAsqw0wvQx8zESIB//IBncxSr JBfU9l0/1OZSdZruo3j7/t2SNdG5N03X3+0dBqkI8PN+YO6ukln1oxnthHvMbJ68O9z/WRka6 xGGV4TAlQiEk87+ByIz3EQ2h8KLCMnCPJOsG/rFY/2+bX3fxGEGh8Y2TEUHqDT6HiqVRpdWcX 1bTjzlqPE0CjQmVEpzDalOnP+Gi4JkqTTQlOlWkx8ZJmTjVDe4= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Date: Sat, 20 Jan 2018 15:30:17 +0100 >> >> Omit extra messages for a memory allocation failure in these functions. > > Why? Do you find the wording “WARNING: Possible unnecessary 'out of memory' message” (from the script “checkpatch.pl”) more reasonable? > This may as well be "delete some stuff because I feel like it". Do you find the Linux allocation failure report insufficient in this use case? Regards, Markus