Received: by 10.223.176.46 with SMTP id f43csp3263653wra; Mon, 22 Jan 2018 11:02:33 -0800 (PST) X-Google-Smtp-Source: AH8x225SBoFwF5Jj14CVI5kbwNRKivLSnGxk98QTfF66SUSorkCOSTlTaGZ2O0baNVBMF5qRyl9m X-Received: by 10.36.179.2 with SMTP id e2mr9879386itf.9.1516647752872; Mon, 22 Jan 2018 11:02:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516647752; cv=none; d=google.com; s=arc-20160816; b=xznwaUv5rOQ8sOCg2ARx/7tUXeDQ8r9p9r0z7Q6E7L5LnWfArqjzpE+0ttF/inLqB8 mSNJzT+jHVCi1ilvbkX7YPGjUttYxIp0xy3wO49UDn2prMn6ydZlF4SQ6PzkYdnKFl8k cyzpnfPrch70lhNbgAe0ZZzxZ2XUOqS3re4zMf6x+AO8mNvTCoGXCRZkvu0LFuCiMij7 jDPLsoQZ3fWyZoW8lBJssPgPUvjKcYFVD8vgDvx4k+gafOljo7Hj6xO6rjdwyT17uN3e oAwqKDqxOmJMlBeTFgePH0YHDP3At2MmsrVO1bD/x7xs4NjInJPOIbkvUFlaaWcHFNye pPYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=dzL+cWt7SbsExrDDUvqCEjW9eoC9hvBezgf39CF6x2A=; b=hunGG1krJej2YXhHL85BD6cgZHchXdmExp1DM3daK8gHzwwmZfx0guWsHPOUFVTjiG vDCbZa4s180rGFgUeBmu67mjH18PHCfV/igqkTHWcLKvggYEyxJ0ITcmYvQ8KxOS0JoA IRhadWK1W/5oxA9v5nBV7FhIn5fYXxtttLZCuRLURBoXmcmlEC+3MHNGO/FkOBAwCjDn az9C/xHh4vwti9vlK5Qac20UpagKYbzDErUIVoSwvt1Za4ZKIIoQ+yQtb36kwvGx5buP 33+CWTapQvHmhAAiA38sJpsbTRBazec4qcicg/DWWOuD2LpBqV0KgXJZiAnEbQpSuTF/ 0tWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w88si8508342ioe.77.2018.01.22.11.02.20; Mon, 22 Jan 2018 11:02:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751345AbeAVTB4 (ORCPT + 99 others); Mon, 22 Jan 2018 14:01:56 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35164 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751170AbeAVTBz (ORCPT ); Mon, 22 Jan 2018 14:01:55 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0MItobT083692 for ; Mon, 22 Jan 2018 14:01:54 -0500 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0b-001b2d01.pphosted.com with ESMTP id 2fnnhbgnng-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 22 Jan 2018 14:01:54 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 22 Jan 2018 19:01:52 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 22 Jan 2018 19:01:49 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0MJ1nDn45416578; Mon, 22 Jan 2018 19:01:49 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B4E8F52049; Mon, 22 Jan 2018 17:54:13 +0000 (GMT) Received: from d06ml001.portsmouth.uk.ibm.com (unknown [9.149.76.127]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id AA04352043; Mon, 22 Jan 2018 17:54:13 +0000 (GMT) Received: from Ivans-MBP-2.mshome.net ([9.145.166.74]) by d06ml001.portsmouth.uk.ibm.com (IBM Domino Release 9.0.1FP8HF179) with ESMTP id 2018012219014894-7107 ; Mon, 22 Jan 2018 19:01:48 +0000 From: Ivan Mikhaylov To: Christian Lamparter Cc: "David S . Miller" , Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write Date: Mon, 22 Jan 2018 22:01:46 +0300 X-Mailer: git-send-email 2.10.1 (Apple Git-78) In-Reply-To: <2818110.k5nooOEKBD@debian64> References: <2818110.k5nooOEKBD@debian64> X-MIMETrack: Itemize by SMTP Server on D06ML001/06/M/IBM(Release 9.0.1FP8HF179 | April 20, 2017) at 22/01/2018 19:01:49, Serialize by Router on D06ML001/06/M/IBM(Release 9.0.1FP8HF179 | April 20, 2017) at 22/01/2018 19:01:49, Serialize complete at 22/01/2018 19:01:49 X-TNEFEvaluated: 1 X-TM-AS-GCONF: 00 x-cbid: 18012219-0020-0000-0000-000003ED7F4B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012219-0021-0000-0000-0000427FC814 Message-Id: <20180122190146.22876-1-ivan@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-22_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801220262 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >Something looks wrong here?! The commit message talks about bit 18, 19 and 20. >However, 0x0800, 0x1000, 0x2000 and are like bit 11, 12 and 13? Furthermore, >what about the EMAC_STACR_STAC_MASK? shouldn't it be 0x1800 now (or delete it >since it doesn't look like it's used anywhere?). Christian, nope, it's all fine there, it's big endian. This commit related only to write operation, I'll check MASK and see what I can do with that.