Received: by 10.223.176.46 with SMTP id f43csp3339267wra; Mon, 22 Jan 2018 12:23:52 -0800 (PST) X-Google-Smtp-Source: AH8x224JH3GV4PupdqtCdtlhaTVhKZcMzmPxMiaHhHl6mYR+RZRnIQNFaWShT5Uz/lmlUbztYE1u X-Received: by 10.107.139.140 with SMTP id n134mr192433iod.34.1516652632667; Mon, 22 Jan 2018 12:23:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516652632; cv=none; d=google.com; s=arc-20160816; b=NQMpJXtlXyabyMXuOCmA/1AjAjYhkbwmLouVPBKDtRxDBZ7jjsUm6saEyxOwByJf1/ XgJWRbykNYPonL2FVbhPqfQZC1qqlFXAXCbGWrbcD6JVrPIvlNngBIAjvrrAxxNme1J5 ruTgxe5qCTP4y7TPPwiuruHmfO3xwaAqz0ROQXEu7EreLqbn1sRVWCmwitq53XxsT7AE bFgZ+XseScweHz2G0QNSQ9zJZRVOHyj89+QsT2BMAKApkrapAslwjk5XaowdgNnpf6QF GwprlUjgcSF2ap+GY0rIlLTfAY1r9RmJQAEwU3EyGgkvH4U2xIinPoYQH0oh266YCXdr XfdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=3jjaK2AKROKLag3LE0/ahoqTblcrZaoEyih/KzgvGWs=; b=0k8PmzvCp6T5Yk0jk5Nbnydhlf97JJPYkJGLPTisGLJYFif4JsxvrJu52ytB32hGIX SLHtONo1mIaObb6bgaP5z/q4OKdLRGZNjTZ0dKslJ4QGTiZmGwb6CLadjvSzS3ia2EwE 9t0Kp16IJemBTWrIt6fpuTHa1WR8mJbZ2OhC1zjMJTZwrJPqFObWd9bNGLP4Gba5fzBv 3weRaYmU3x4YHJZoKvJmjduLF4YvqNqUzsAuftAGvJKQIQrG4cQHrXNjlLRWcwuS8xlm t77Hq/6JTU3/5KMsTxqApmK5btRJRqkTynmQtjF9vFF5+AXnQt02yihHbRB0XtlfHtUH KxGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CoJyaYVB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 87si13424753iop.223.2018.01.22.12.23.39; Mon, 22 Jan 2018 12:23:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CoJyaYVB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751819AbeAVUWo (ORCPT + 99 others); Mon, 22 Jan 2018 15:22:44 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:46567 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751588AbeAVUNn (ORCPT ); Mon, 22 Jan 2018 15:13:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3jjaK2AKROKLag3LE0/ahoqTblcrZaoEyih/KzgvGWs=; b=CoJyaYVB4LWg06pC/wknBgoLR FqxyqPbui4skbHkVfL9Ah6m1U+dHtjFdsK6MWKhw0Eyd4undZZr1zDT0jSxcqwPLPbUGvp4+AYCh8 i+F9cvCM9Bl8ZLgRSpa710fce4wu7tOpOHy2vyuuInV7/Jt4UlyTniQ/mKkCilnAPZTQ8Jd7/XD3B 343Ib8pQz6pgQybsMB+e74eFUwvUrypWi0Bi9TmXtuz1P2nDkOOTa9U6gSe7Sad8Z5AhPM3uwg+xC 2fwH9MhhPz+N3pN2aW9JEOOYEhSdvmgL1ZzBaUpDXs9lcCUXnZFo9bCoShfbUKgM55P/6xkp9MIi3 yQK03t5Qw==; Received: from 178.114.226.247.wireless.dyn.drei.com ([178.114.226.247] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1ediTN-0007dh-Mt; Mon, 22 Jan 2018 20:13:42 +0000 From: Christoph Hellwig To: viro@zeniv.linux.org.uk Cc: Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/36] net: remove sock_no_poll Date: Mon, 22 Jan 2018 21:12:24 +0100 Message-Id: <20180122201243.31610-18-hch@lst.de> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180122201243.31610-1-hch@lst.de> References: <20180122201243.31610-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that sock_poll handles a NULL ->poll or ->poll_mask there is no need for a stub. Signed-off-by: Christoph Hellwig --- crypto/af_alg.c | 1 - crypto/algif_hash.c | 2 -- crypto/algif_rng.c | 1 - drivers/isdn/mISDN/socket.c | 1 - drivers/net/ppp/pptp.c | 1 - include/net/sock.h | 2 -- net/bluetooth/bnep/sock.c | 1 - net/bluetooth/cmtp/sock.c | 1 - net/bluetooth/hidp/sock.c | 1 - net/core/sock.c | 6 ------ 10 files changed, 17 deletions(-) diff --git a/crypto/af_alg.c b/crypto/af_alg.c index 05b084e216ac..592797ec8075 100644 --- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -345,7 +345,6 @@ static const struct proto_ops alg_proto_ops = { .sendpage = sock_no_sendpage, .sendmsg = sock_no_sendmsg, .recvmsg = sock_no_recvmsg, - .poll = sock_no_poll, .bind = alg_bind, .release = af_alg_release, diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c index 76d2e716c792..d5f323c1efc5 100644 --- a/crypto/algif_hash.c +++ b/crypto/algif_hash.c @@ -293,7 +293,6 @@ static struct proto_ops algif_hash_ops = { .mmap = sock_no_mmap, .bind = sock_no_bind, .setsockopt = sock_no_setsockopt, - .poll = sock_no_poll, .release = af_alg_release, .sendmsg = hash_sendmsg, @@ -401,7 +400,6 @@ static struct proto_ops algif_hash_ops_nokey = { .mmap = sock_no_mmap, .bind = sock_no_bind, .setsockopt = sock_no_setsockopt, - .poll = sock_no_poll, .release = af_alg_release, .sendmsg = hash_sendmsg_nokey, diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c index 150c2b6480ed..22df3799a17b 100644 --- a/crypto/algif_rng.c +++ b/crypto/algif_rng.c @@ -106,7 +106,6 @@ static struct proto_ops algif_rng_ops = { .bind = sock_no_bind, .accept = sock_no_accept, .setsockopt = sock_no_setsockopt, - .poll = sock_no_poll, .sendmsg = sock_no_sendmsg, .sendpage = sock_no_sendpage, diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c index c5603d1a07d6..c84270e16bdd 100644 --- a/drivers/isdn/mISDN/socket.c +++ b/drivers/isdn/mISDN/socket.c @@ -746,7 +746,6 @@ static const struct proto_ops base_sock_ops = { .getname = sock_no_getname, .sendmsg = sock_no_sendmsg, .recvmsg = sock_no_recvmsg, - .poll = sock_no_poll, .listen = sock_no_listen, .shutdown = sock_no_shutdown, .setsockopt = sock_no_setsockopt, diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c index 6dde9a0cfe76..87f892f1d0fe 100644 --- a/drivers/net/ppp/pptp.c +++ b/drivers/net/ppp/pptp.c @@ -627,7 +627,6 @@ static const struct proto_ops pptp_ops = { .socketpair = sock_no_socketpair, .accept = sock_no_accept, .getname = pptp_getname, - .poll = sock_no_poll, .listen = sock_no_listen, .shutdown = sock_no_shutdown, .setsockopt = sock_no_setsockopt, diff --git a/include/net/sock.h b/include/net/sock.h index f90685441143..1a5c31d1893a 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -1578,8 +1578,6 @@ int sock_no_connect(struct socket *, struct sockaddr *, int, int); int sock_no_socketpair(struct socket *, struct socket *); int sock_no_accept(struct socket *, struct socket *, int, bool); int sock_no_getname(struct socket *, struct sockaddr *, int *, int); -__poll_t sock_no_poll(struct file *, struct socket *, - struct poll_table_struct *); int sock_no_ioctl(struct socket *, unsigned int, unsigned long); int sock_no_listen(struct socket *, int); int sock_no_shutdown(struct socket *, int); diff --git a/net/bluetooth/bnep/sock.c b/net/bluetooth/bnep/sock.c index b5116fa9835e..00deacdcb51c 100644 --- a/net/bluetooth/bnep/sock.c +++ b/net/bluetooth/bnep/sock.c @@ -175,7 +175,6 @@ static const struct proto_ops bnep_sock_ops = { .getname = sock_no_getname, .sendmsg = sock_no_sendmsg, .recvmsg = sock_no_recvmsg, - .poll = sock_no_poll, .listen = sock_no_listen, .shutdown = sock_no_shutdown, .setsockopt = sock_no_setsockopt, diff --git a/net/bluetooth/cmtp/sock.c b/net/bluetooth/cmtp/sock.c index ce86a7bae844..e08f28fadd65 100644 --- a/net/bluetooth/cmtp/sock.c +++ b/net/bluetooth/cmtp/sock.c @@ -178,7 +178,6 @@ static const struct proto_ops cmtp_sock_ops = { .getname = sock_no_getname, .sendmsg = sock_no_sendmsg, .recvmsg = sock_no_recvmsg, - .poll = sock_no_poll, .listen = sock_no_listen, .shutdown = sock_no_shutdown, .setsockopt = sock_no_setsockopt, diff --git a/net/bluetooth/hidp/sock.c b/net/bluetooth/hidp/sock.c index 008ba439bd62..1eaac01f85de 100644 --- a/net/bluetooth/hidp/sock.c +++ b/net/bluetooth/hidp/sock.c @@ -208,7 +208,6 @@ static const struct proto_ops hidp_sock_ops = { .getname = sock_no_getname, .sendmsg = sock_no_sendmsg, .recvmsg = sock_no_recvmsg, - .poll = sock_no_poll, .listen = sock_no_listen, .shutdown = sock_no_shutdown, .setsockopt = sock_no_setsockopt, diff --git a/net/core/sock.c b/net/core/sock.c index 1211159718ad..1943a79befea 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2496,12 +2496,6 @@ int sock_no_getname(struct socket *sock, struct sockaddr *saddr, } EXPORT_SYMBOL(sock_no_getname); -__poll_t sock_no_poll(struct file *file, struct socket *sock, poll_table *pt) -{ - return 0; -} -EXPORT_SYMBOL(sock_no_poll); - int sock_no_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) { return -EOPNOTSUPP; -- 2.14.2