Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/5] USB: serial: f81232: add high baud rate support
To:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Johan Hovold <johan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        USB <linux-usb@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Peter H <peter_hong@fintek.com.tw>,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
References: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com>
 <1516607927-8887-2-git-send-email-hpeter+linux_kernel@gmail.com>
 <CAHp75VdFFdpp+fkqqjfm82OsLRTiY2W3M3+AHq_st9zJrBRraQ@mail.gmail.com>
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Message-ID: <7d8c1ff5-06fa-28f3-c5e8-3211497a6b17@gmail.com>
Date:   Tue, 23 Jan 2018 10:08:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <CAHp75VdFFdpp+fkqqjfm82OsLRTiY2W3M3+AHq_st9zJrBRraQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andy,

Andy Shevchenko 於 2018/1/22 下午 10:55 寫道:
> On Mon, Jan 22, 2018 at 9:58 AM, Ji-Ze Hong (Peter Hong)
> <hpeter@gmail.com> wrote:
>> The F81232 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates
>> can be up to 1.5Mbits with 24MHz.
>>
>> F81232 Clock registers (106h)
>>
>> Bit1-0:     Clock source selector
>>                      00: 1.846MHz.
>>                      01: 18.46MHz.
>>                      10: 24MHz.
>>                      11: 14.77MHz.
> 
> Hmm... Why not to provide a proper clk driver (based on table variant
> of clk-divider) and use it here?
> 
> 

It seems too complex to use clock framework in this driver.
What do you think about this, Johan ?

Thanks
-- 
With Best Regards,
Peter Hong