Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1516696324.7000.1185.camel@linux.intel.com>
Subject: Re: [PATCH v1] x86/io: Define readq()/writeq() to use 64-bit type
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     hpa@zytor.com, "Mehta, Sohil" <sohil.mehta@intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     "mitake@dcl.info.waseda.ac.jp" <mitake@dcl.info.waseda.ac.jp>
Date:   Tue, 23 Jan 2018 10:32:04 +0200
In-Reply-To: <FDFCAF1F-F4F8-4376-AD78-6208008F63DE@zytor.com>
References: <20180119143322.16555-1-andriy.shevchenko@linux.intel.com>
         <1516667578.153063.78.camel@intel.com>
         <FDFCAF1F-F4F8-4376-AD78-6208008F63DE@zytor.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-01-22 at 16:46 -0800, hpa@zytor.com wrote:
> On January 22, 2018 4:32:14 PM PST, "Mehta, Sohil" <sohil.mehta@intel.
> com> wrote:
> > On Fri, 2018-01-19 at 16:33 +0200, Andy Shevchenko wrote:

> > > +build_mmio_read(readq, "q", unsigned long long, "=r", :"memory")
> > > +build_mmio_read(__readq, "q", unsigned long long, "=r", )
> > > +build_mmio_write(writeq, "q", unsigned long long, "r", :"memory")
> > > +build_mmio_write(__writeq, "q", unsigned long long, "r", )
> > >  
> > >  #define readq_relaxed(a)	__readq(a)
> > >  #define writeq_relaxed(v, a)	__writeq(v, a)
> > 
> > The patch works for me:
> > 
> > Tested-by: Sohil Mehta <sohil.mehta@intel.com>
> > 

> Wouldn't simply u64 make more sense?

It would break a common style used in this module for the rest of
accessors. 

So, I prefer to go with unsigned long long and change later, if needed,
from POD types to uNN ones in entire file.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy