Received: by 10.223.176.46 with SMTP id f43csp4144963wra; Tue, 23 Jan 2018 05:05:39 -0800 (PST) X-Google-Smtp-Source: AH8x224juTMmbLS+SsfgcF10+jHNT3fUicUmXqw5M//S0/STCzsea7zXFapU1tzDHw6GRnnIoYfH X-Received: by 2002:a17:902:8544:: with SMTP id d4-v6mr5752273plo.167.1516712739102; Tue, 23 Jan 2018 05:05:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516712739; cv=none; d=google.com; s=arc-20160816; b=HdcubwUNLQzfegrBKwJm9EvRdbZ6xbic3TpR5wMJJHyQ0IeVgocvhEb3OTBPa9wv2J GcoSr0MsBTkd/hT6FYRN33LkCMH8byJpVzI7eRwtSF7LA8kqpJ4iu8v88lN7TuR4U82G 3Rxmn8kq5/1NmKo4bTfeCw9sZ1HmgseN/oFUgu5+RuJccaiMYZN+87ViU5f8HsWQFNpj qZW4Q1D3qA7ELJ8tgl/5Qvf9q4Rv5kDna371GMBTdlovTeOf5n453YkFNxDj0j46AVfu Dh+f+diFzgDZbzk4toLmqDzDFHwwIH9V4LNTiXpck2gLn5EIuYoKLn6PD75JiTzAMiQY /c2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=rmwL0jGuIFV0k2GRtM4rFiYSZQHvU1hV+younJq5OZk=; b=BGf1ai0QCXcr4g1ldPzJgDX6bQ2FnS3Oc7CA475gky02jBglEvcxh41UgGArnyU5ME xRG3AYQf7HcjNwnDutyvsxU+vbJTNZ3/baSxxultquR1YyM9g6mdCOOYqgtUyNc6Y3Na ySayVJj/fD5WsV1aKp+Dw3kr3HWiBmV7DlOdtakQVp7k9kCOX0bbmtqaPA5O7dyTxQCC CS/rDx9SB4T2SN5adPUHOzlvb3tykr9R2UnA1ighuHsk7TQdLgsR+6IX7/fGislCEEb0 og0gAf0k2V3nSXoUjiEEsT3Z/sVXJjZwYsQ02WeKa4DK2TmIq6dgOy7IbKe9JwP0Ns6t XpOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NZ/ovmkp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9si1451452pfk.333.2018.01.23.05.05.24; Tue, 23 Jan 2018 05:05:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NZ/ovmkp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbeAWNEq (ORCPT + 99 others); Tue, 23 Jan 2018 08:04:46 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:40907 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbeAWNEo (ORCPT ); Tue, 23 Jan 2018 08:04:44 -0500 Received: by mail-wr0-f194.google.com with SMTP id 100so478081wrb.7 for ; Tue, 23 Jan 2018 05:04:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rmwL0jGuIFV0k2GRtM4rFiYSZQHvU1hV+younJq5OZk=; b=NZ/ovmkpbD060QcsLTlSVC+OTMXb8krHKxx6G3Vfnd7TjxtoZGsNiSwvDZYxNTDt6k DGZjxWQcqHxO4P4ZK7VBUMLx5WJ3naUQyTgasx2G2Y6fe1ZpiIk2pJRxT7meijDQBmRe YIph6vyAq+n5F6iZd2/LNO/MVtMxOeorO6EjE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rmwL0jGuIFV0k2GRtM4rFiYSZQHvU1hV+younJq5OZk=; b=VNOaGSHznJQZQi1BCM0boXwdHOyBJkUrcO6SS/Bn0potqL/0l0ZfMeQQePme58pyZk zAU51XI/TmGFMSZwaLHltzHCh+H+mSDo0TLyQKj9OiNBtRWLMQo6KzFmfHjUEsW6SSLI usTE5CDaG5cR1rJYXHFB5QmjDsbRAPFFBOMRcXShYb5rGZsullK5Qd2XPGGHEhB1pnz3 sdaXv2KeBtvktgsi+GweOCoXckFxryzI8i3Ty/6xVotELlQWFsqYPwsXNSgki+w3jtpQ phF3zAU1bbZ3TvznCCqjQRGrby/O+btTy/jadSOMDGrwJ3IICUBD2brms0zJuYeS5DZ0 XlCQ== X-Gm-Message-State: AKwxytesowcPWYMX/cYUoLEN2l4NmRComaZrekJ4V+5QjtKyWrQIdJ/M rs/QUXuvL35Iwq9pb3j2qe3pKBuQUd8= X-Received: by 10.223.165.78 with SMTP id j14mr2272826wrb.238.1516712683205; Tue, 23 Jan 2018 05:04:43 -0800 (PST) Received: from dell ([2.27.167.60]) by smtp.gmail.com with ESMTPSA id z39sm441012wrz.20.2018.01.23.05.04.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2018 05:04:42 -0800 (PST) Date: Tue, 23 Jan 2018 13:04:40 +0000 From: Lee Jones To: SF Markus Elfring Cc: linux-omap@vger.kernel.org, Tony Lindgren , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] mfd/omap-usb-tll: Return an error code only as a constant in usbtll_omap_probe() Message-ID: <20180123130440.lgfoeq4rzsa2e4gk@dell> References: <367e77d8-3a65-2c12-5e79-75a626b65f41@users.sourceforge.net> <20180122155057.7eiu53l6xjls6uga@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180122155057.7eiu53l6xjls6uga@dell> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jan 2018, Lee Jones wrote: > On Mon, 15 Jan 2018, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Mon, 15 Jan 2018 14:00:45 +0100 > > > > * Return an error code without storing it in an intermediate variable. > > > > * Delete the label "err_clk_alloc" and local variable "ret" > > which became unnecessary with this refactoring. > > > > Signed-off-by: Markus Elfring > > --- > > drivers/mfd/omap-usb-tll.c | 12 +++--------- > > 1 file changed, 3 insertions(+), 9 deletions(-) > > Applied, thanks. This patch does not apply. Please rebase and resend. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog