Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v18 08/10] drm/omapdrm: Use backlight_enable/disable
 helpers
To:     Meghana Madhyastha <meghana.madhyastha@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <cover.1516632387.git.meghana.madhyastha@gmail.com>
 <30d5b26c3c7d75de3d2ab3cff9dee67084fc3caf.1516632388.git.meghana.madhyastha@gmail.com>
From:   =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= <noralf@tronnes.org>
Message-ID: <fdc96264-b927-38d4-908b-3e7328add06e@tronnes.org>
Date:   Tue, 23 Jan 2018 15:20:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <30d5b26c3c7d75de3d2ab3cff9dee67084fc3caf.1516632388.git.meghana.madhyastha@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Den 22.01.2018 15.54, skrev Meghana Madhyastha:
> Use backlight_enable/disable helpers instead of changing
> the property and calling backlight_update_status for cleaner
> and simpler code and also to avoid repetitions.
>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> ---

Reviewed-by: Noralf Trønnes<noralf@tronnes.org>


>   drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 11 ++---------
>   1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> index e065f7e10..ac9596251 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> @@ -87,11 +87,7 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev)
>   	}
>   
>   	gpiod_set_value_cansleep(ddata->enable_gpio, 1);
> -
> -	if (ddata->backlight) {
> -		ddata->backlight->props.power = FB_BLANK_UNBLANK;
> -		backlight_update_status(ddata->backlight);
> -	}
> +	backlight_enable(ddata->backlight);
>   
>   	dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;
>   
> @@ -106,10 +102,7 @@ static void panel_dpi_disable(struct omap_dss_device *dssdev)
>   	if (!omapdss_device_is_enabled(dssdev))
>   		return;
>   
> -	if (ddata->backlight) {
> -		ddata->backlight->props.power = FB_BLANK_POWERDOWN;
> -		backlight_update_status(ddata->backlight);
> -	}
> +	backlight_disable(ddata->backlight);
>   
>   	gpiod_set_value_cansleep(ddata->enable_gpio, 0);
>   	regulator_disable(ddata->vcc_supply);