Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Haiyang Zhang <haiyangz@microsoft.com>
To:     Mohammed Gamal <mgamal@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        KY Srinivasan <kys@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "cavery@redhat.com" <cavery@redhat.com>,
        "otubo@redhat.com" <otubo@redhat.com>
Subject: RE: [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012
 hosts
Thread-Topic: [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012
 hosts
Thread-Index: AQHTlC1e8Zik2Qtg9U24YPQnRmfoY6OBmUDA
Date:   Tue, 23 Jan 2018 15:43:13 +0000
Message-ID: <DM5PR2101MB0871BBCD59762D1884C6CFFDCAE30@DM5PR2101MB0871.namprd21.prod.outlook.com>
References: <1516700045-32142-1-git-send-email-mgamal@redhat.com>
In-Reply-To: <1516700045-32142-1-git-send-email-mgamal@redhat.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=haiyangz@microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-01-23T15:43:10.8752251Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
x-originating-ip: [69.130.166.81]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1096;7:qmzZDISGgd7tfuaL4pPeIfwQxVryPOtoNmGwoHOb9C5rALWWxmu3+g8aMpp72S2FnLCDGWB+7U73JS+2TAFv/jXjb11gyCqieqE2zM95u5qLSGJAidjVQHS5UDjkh+Hw9bnMKA+NHPLKr+IwWGzt6g9xGTTEq5cWfcMD8+WCaRVnAECT0H6n6+2QQs2ffk8XR0e4ZOWscEQXnuDwuztqyHwsbOeP2Vaq2hP0ZEfuFK7wz2PJJ8J6QxCWoTRxMn4q
x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR;
x-ms-office365-filtering-correlation-id: 43f64320-a97b-4213-689c-08d562780362
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB1096;
x-ms-traffictypediagnostic: DM5PR2101MB1096:
x-microsoft-antispam-prvs: <DM5PR2101MB10965D7D2F5A802F66ABA2C1CAE30@DM5PR2101MB1096.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231046)(2400081)(944501161)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041288)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB1096;BCL:0;PCL:0;RULEID:(100000803126)(100110400120);SRVR:DM5PR2101MB1096;
x-forefront-prvs: 05610E64EE
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(39860400002)(346002)(39380400002)(366004)(13464003)(199004)(189003)(6436002)(33656002)(9686003)(55016002)(54906003)(25786009)(2950100002)(86612001)(4326008)(59450400001)(6116002)(53546011)(110136005)(316002)(106356001)(8936002)(10290500003)(7736002)(81166006)(8676002)(26005)(6346003)(3846002)(305945005)(229853002)(102836004)(81156014)(6506007)(478600001)(97736004)(22452003)(2900100001)(76176011)(2501003)(5660300001)(14454004)(3280700002)(8990500004)(3660700001)(6246003)(53936002)(10090500001)(74316002)(86362001)(105586002)(7696005)(68736007)(99286004)(66066001)(2906002)(345774005)(5250100002)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1096;H:DM5PR2101MB0871.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=haiyangz@microsoft.com; 
x-microsoft-antispam-message-info: /IzGiK4AWr93COaM7KAT5kKAetxPd0aI0Kjlkd2a5R5QITTBSIl+PiHss/qUVNiTO2oqaZU47lCRkMcYjjmNJQ==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43f64320-a97b-4213-689c-08d562780362
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2018 15:43:13.3450
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1096
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Mohammed Gamal [mailto:mgamal@redhat.com]
> Sent: Tuesday, January 23, 2018 4:34 AM
> To: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; KY
> Srinivasan <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>;
> Stephen Hemminger <sthemmin@microsoft.com>; vkuznets@redhat.com;
> cavery@redhat.com; otubo@redhat.com; Mohammed Gamal
> <mgamal@redhat.com>
> Subject: [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012
> hosts
>=20
> Commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
> introduced a regression that caused VMs not to shutdown after
> netvsc_device_remove() is called. This is caused by GPADL teardown
> sequence change, and while that was necessary to fix issues with Win2016
> hosts, it did introduce a regression for earlier versions.
>=20
> Prior to commit 0cf737808 the call sequence in netvsc_device_remove() was
> as follows (as implemented in netvsc_destroy_buf()):
> 1- Send NVSP_MSG1_TYPE_REVOKE_RECV_BUF message
> 2- Teardown receive buffer GPADL
> 3- Send NVSP_MSG1_TYPE_REVOKE_SEND_BUF message
> 4- Teardown send buffer GPADL
> 5- Close vmbus
>=20
> This didn't work for WS2016 hosts. Commit 0cf737808 split
> netvsc_destroy_buf() into two functions and rearranged the order as follo=
ws
> 1- Send NVSP_MSG1_TYPE_REVOKE_RECV_BUF message
> 2- Send NVSP_MSG1_TYPE_REVOKE_SEND_BUF message
> 3- Close vmbus
> 4- Teardown receive buffer GPADL
> 5- Teardown send buffer GPADL
>=20
> That worked well for WS2016 hosts, but for WS2012 hosts it prevented VMs
> from shutting down.
>=20
> This patch series works around this problem. The first patch splits
> netvsc_revoke_buf() and netvsc_teardown_gpadl() into two finer grained
> functions for tearing down send and receive buffers individally. The seco=
nd
> patch uses the finer grained functions to implement the teardown sequence
> according to the host's version. We keep the behavior introduced in
> 0cf737808ae7 for Windows
> 2016 hosts, while we re-introduce the old sequence for earlier verions.
>=20
> Mohammed Gamal (2):
>   hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()
>   hv_netvsc: Change GPADL teardown order according to Hyper-V version
>=20
>  drivers/net/hyperv/netvsc.c | 50
> +++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 42 insertions(+), 8 deletions(-)

Thank you for the patches. We are testing them internally.

- Haiyang