Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 23 Jan 2018 11:28:44 -0500 (EST)
Message-Id: <20180123.112844.1256276359022440138.davem@davemloft.net>
To:     garsilva@embeddedor.com
Cc:     kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180123092100.Horde.eCxo2t_trgqhviCw7bQxRTz@gator4166.hostgator.com>
References: <20180122222213.GA14829@embeddedor.com>
        <20180123.100217.2156136452621715003.davem@davemloft.net>
        <20180123092100.Horde.eCxo2t_trgqhviCw7bQxRTz@gator4166.hostgator.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Tue, 23 Jan 2018 09:21:00 -0600

> 
> Quoting David Miller <davem@davemloft.net>:
> 
>> From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
>> Date: Mon, 22 Jan 2018 16:22:13 -0600
>>
>>> Assign true or false to boolean variables instead of an integer value.
>>>
>>> This issue was detected with the help of Coccinelle.
>>>
>>> Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build
>>> message directly.")
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>>
>> Please don't use the word "fix".
>>
>> '0' is the same as 'false', it's just that the latter is more
>> consistent type wise.
>>
> 
> So "Use true and false for boolean value" would be a better subject?

Yes.