Received: by 10.223.176.46 with SMTP id f43csp4390065wra; Tue, 23 Jan 2018 08:45:26 -0800 (PST) X-Google-Smtp-Source: AH8x226zmPhSUBWnKnElp9YMc9swNKDqy4wbcXgkwuhu20bnG0sQAYi415cV4FhRtANNTVGR9Uzz X-Received: by 10.107.47.92 with SMTP id j89mr4260798ioo.222.1516725926109; Tue, 23 Jan 2018 08:45:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516725926; cv=none; d=google.com; s=arc-20160816; b=ljrzZSAsBOVB4lQvt0SV9hUVEUExQzwbcdIEdWSYDdMGPz1odnRENbRPUppkiwQVVv I8tdfl5fQn51BmTT6n00GAZU0+Sh7w02MGokyMQy/moPk70+48XqqtLhGJC+hCYu67zw U4ooB3ZDazPUNR4xqzQ6b5xpMPbT1LRT5GueGuz1Kyjr8q7jVASFmHKbzMqV4xGtFtCW 2h0MFCD1OdZtw+T9ZTDVPdAW7b6zTJ7j0pIZmV/FPQdFP23MWkLNvCORD4B4L+Mbu3s1 UQFzzhONElf103CGz78gxO7hvOG4+9IT2OpIV23KaBroQ+kyXqYAix/WVb5WyRBa81xv EZ7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=BzG371Chl7cFStmbJBkCB/AaXpSKvaOCDCJuD2Ot3dU=; b=Nvsp015Wtq5uB8EalBMqlUtTauaJsn1zJcVUwRRajveAtuYKXuGl/ZmiBgOr2ENbWs hNC4JRT0ddMI1sXjnyTSrNh5VeMS1Lw8rcfc2RpKNuC5QertP+0Hj9U265fUSkGQWiFE REcCGPG/quFlKWxV1ftrhTt+U/wNzPt75DuGjpFAEjEUJNv5Sn7Ygb1fPhKsNtpc5KfB jYwWCA2f7cgP/AVgQ2m79wDkG2+9s4O5Q+rbbcTvdgoU9NP09cWct59YKlLq/EBVkXen L7aHGs+tIcdrhKbRvg4y+FChb5EZX0MeeNsP4JL+3ox7d22tB9eTGstgSQUEHslTArDB BGFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n100si9066793ioo.19.2018.01.23.08.45.12; Tue, 23 Jan 2018 08:45:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751682AbeAWQow (ORCPT + 99 others); Tue, 23 Jan 2018 11:44:52 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:41244 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbeAWQou (ORCPT ); Tue, 23 Jan 2018 11:44:50 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0NGgHmT092697 for ; Tue, 23 Jan 2018 11:44:50 -0500 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fp780nfrx-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 23 Jan 2018 11:44:49 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Jan 2018 16:44:47 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 23 Jan 2018 16:44:45 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0NGijPX64225488; Tue, 23 Jan 2018 16:44:45 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E67AA42041; Tue, 23 Jan 2018 16:38:02 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB87E4203F; Tue, 23 Jan 2018 16:38:02 +0000 (GMT) Received: from d06ml001.portsmouth.uk.ibm.com (unknown [9.149.76.127]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 23 Jan 2018 16:38:02 +0000 (GMT) Received: from ivans-mbp-2.moscow.ru.ibm.com ([9.138.252.109]) by d06ml001.portsmouth.uk.ibm.com (IBM Domino Release 9.0.1FP8HF179) with ESMTP id 2018012316444505-12926 ; Tue, 23 Jan 2018 16:44:45 +0000 From: Ivan Mikhaylov To: Christian Lamparter Cc: "David S . Miller" , Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write Date: Tue, 23 Jan 2018 19:44:44 +0300 X-Mailer: git-send-email 2.10.1 (Apple Git-78) In-Reply-To: <9040166.kDGxHD26M5@debian64> References: <9040166.kDGxHD26M5@debian64> X-MIMETrack: Itemize by SMTP Server on D06ML001/06/M/IBM(Release 9.0.1FP8HF179 | April 20, 2017) at 23/01/2018 16:44:45, Serialize by Router on D06ML001/06/M/IBM(Release 9.0.1FP8HF179 | April 20, 2017) at 23/01/2018 16:44:45, Serialize complete at 23/01/2018 16:44:45 X-TNEFEvaluated: 1 X-TM-AS-GCONF: 00 x-cbid: 18012316-0020-0000-0000-000003EDE06D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012316-0021-0000-0000-000042802C11 Message-Id: <20180123164444.47989-1-ivan@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-23_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801230229 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So if someone tries to #define EMAC_STACR_STAC_WRITE BIT(18) it would be > 0x40000 instead. This is where the confusion is coming from. Can you please > at least mention this somewhere that all the bits in the commit message are > in "MSB 0" format? It's confusing enough as it is ;). Yeap, sure, will do. > Well, the MASK is not used and it now looks odd. So you might as well > delete it. Maybe as well as all the unused EMACX_STACR_STAC_IND_* macros? I'll check and delete if it's not used anywhere. Thanks for finding :)