Received: by 10.223.176.46 with SMTP id f43csp4437643wra; Tue, 23 Jan 2018 09:23:43 -0800 (PST) X-Google-Smtp-Source: AH8x224fdbM9vT8S6jARYY1TNLCSAM2DVUymROhtGQvCWA+UoUWEXyFPqdiWW2nsUHwHpnd9ILoJ X-Received: by 10.36.138.134 with SMTP id v128mr4657275itd.153.1516728222928; Tue, 23 Jan 2018 09:23:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516728222; cv=none; d=google.com; s=arc-20160816; b=a6qpDIWKCA/wyj4c+WxHYPLNAmehk2OqHuUc1GORWci9TP8ypAPdtL3UKP4QXT5mwn aTiMmnA/lTrtwIk9mWNeXLwJTSKSbc7PuhgRX7+kYr6AuW0eo4+MAgTOgcE5dIUFejYq /EW1C0waEXYLjAfLcLZ9rE0vU7HgyybILjoFhAMu1nugHkjKhFnZR026s/FBzzf4ZZfw QKGGiBFf1ujxPuQon2wzIc6poqJNb7auxghFEkZRToQ12hqCR8ZUzXrKBiljtm2jckkx /YuNzJEw1+D+Fzv60IWaXi8zdy2idzNvkSjLYelfffD0KzRfYJbT3get4l9++1ihob85 cnhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=lFCedY9Hn020E74Wk8CS2S8dew96IDPBpYGE5n1uXHw=; b=ukcKNIVCKV935UimN0LrLIbHHXy+1WBHdQm7EnQI0xVS5WfeorQuQQNYu6Avr6rSVe hLW8/nsmH/ltRFGJJKHtv9V0HFbmnZHiSr6TdBOpiH/0NBu4FB9VERUa6vKHvw40A36A WVsVDY2lQJV0X8lGWkhyNH1N5OEnR/IDDmRC8RDsNqADJYFHqulkH3jvJ3VkhJMBJghI /mRqUp2gpnTDARRZmAgn0Eqn26GHeGTN9HHnmDGCeqkCE9a88V1A8jiLGS0OhUHria0E eS5BEF8kThIk35ZOOKjHFKNX7BoBIC8+wBXxV++atrmZeGZ5KbSJy7t5wKsfJ11Ybas5 SLwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=XcAXrHKs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o127si8440546ito.127.2018.01.23.09.23.30; Tue, 23 Jan 2018 09:23:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=XcAXrHKs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbeAWRWx (ORCPT + 99 others); Tue, 23 Jan 2018 12:22:53 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:38237 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbeAWRWu (ORCPT ); Tue, 23 Jan 2018 12:22:50 -0500 Received: by mail-qt0-f196.google.com with SMTP id z10so3250739qti.5 for ; Tue, 23 Jan 2018 09:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lFCedY9Hn020E74Wk8CS2S8dew96IDPBpYGE5n1uXHw=; b=XcAXrHKsbAyGgROHhY5aWYK+0V3UZmthVzJTyIqTFXUYtuKKf9a/xXAjD86U1MKsGi o7xBeFClGSsiCbOC65OhhSstHigKYeS8vPxjVI1VF1A/GNQLyXjq8cRi4OBmeJiXnHyP qanSxi5OsE1Oar9BrL+C5jQ70vLtfw+ZGQFHAqz+GjK5ag8BVTODJUYDJA09MrXJmSE7 4vS9efRV1xoEMazIPSBcxP8Na8pAHaypvYZw/ehOMtkH0VHZOB8TaMyEYeItmKt15xqv 1TwjzlSEgYZRbAgRZGvz7DdT4HCoId1tSeK8VLfSFfkX/aPFEmOq39JFe8uXaFz+dDZb E0IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=lFCedY9Hn020E74Wk8CS2S8dew96IDPBpYGE5n1uXHw=; b=kjmikRzVdSn2DZPjAkPZbkwapYWYa/h+OXEjakH4WqKuirQUer0qih55mX+CLQk1yg lnjkJKrsOHrsZ8g08kO5/WKKcrY/sKnERv/ESYppFBgsdBJ5DGRENHvIxJHJpuhL3Yg4 H/BarVXGHGcf9BcWgdWfgT8FDnODSY+JqsEDdAewbOF6Q3BWy/UWnlMOU6065gyaTNrL VFmId1e1sP3mG6K+PXllNeZfbLYZ8IMi0Ufym2/jggOfbpc6ZGrn0zW4DrKN5B354Yqs BgBf3vasm2Yz2qCzcCGohi9VogVfUpVhHE1f+/30qTlXGK/lyehs3LtV3ViBxn610dgh 5uyA== X-Gm-Message-State: AKwxytd/ahdDOcoQGfHcNFwLesAdERWjANBqSDHKyk5WoGx0CUKhUKnJ 4vbx7m2ss34z/ee/K8Ua5s4= X-Received: by 10.55.164.144 with SMTP id n138mr4571296qke.67.1516728169370; Tue, 23 Jan 2018 09:22:49 -0800 (PST) Received: from localhost (dhcp-ec-8-6b-ed-7a-cf.cpe.echoes.net. [72.28.5.223]) by smtp.gmail.com with ESMTPSA id i39sm616020qte.19.2018.01.23.09.22.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jan 2018 09:22:48 -0800 (PST) Date: Tue, 23 Jan 2018 09:22:46 -0800 From: Tejun Heo To: Sergey Senozhatsky Cc: Steven Rostedt , Sergey Senozhatsky , Petr Mladek , akpm@linux-foundation.org, linux-mm@kvack.org, Cong Wang , Dave Hansen , Johannes Weiner , Mel Gorman , Michal Hocko , Vlastimil Babka , Peter Zijlstra , Linus Torvalds , Jan Kara , Mathieu Desnoyers , Tetsuo Handa , rostedt@home.goodmis.org, Byungchul Park , Pavel Machek , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup Message-ID: <20180123172246.GG1771050@devbig577.frc2.facebook.com> References: <20180117134201.0a9cbbbf@gandalf.local.home> <20180119132052.02b89626@gandalf.local.home> <20180120071402.GB8371@jagdpanzerIV> <20180120104931.1942483e@gandalf.local.home> <20180121141521.GA429@tigerII.localdomain> <20180123064023.GA492@jagdpanzerIV> <20180123095652.5e14da85@gandalf.local.home> <20180123152130.GB429@tigerII.localdomain> <20180123104121.2ef96d81@gandalf.local.home> <20180123160153.GC429@tigerII.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180123160153.GC429@tigerII.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Sergey. On Wed, Jan 24, 2018 at 01:01:53AM +0900, Sergey Senozhatsky wrote: > On (01/23/18 10:41), Steven Rostedt wrote: > [..] > > We can have more. But if printk is causing printks, that's a major bug. > > And work queues are not going to fix it, it will just spread out the > > pain. Have it be 100 printks, it needs to be fixed if it is happening. > > And having all printks just generate more printks is not helpful. Even > > if we slow them down. They will still never end. > > Dropping the messages is not the solution either. The original bug report > report was - this "locks up my kernel". That's it. That's all people asked > us to solve. > > With WQ we don't lockup the kernel, because we flush printk_safe in > preemptible context. And people are very much expected to fix the > misbehaving consoles. But that should not be printk_safe problem. I really don't care as long as it's robust enough. Thanks. -- tejun