Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Liang, Kan" <kan.liang@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>,
        Andi Kleen <ak@linux.intel.com>
CC:     Stephane Eranian <eranian@google.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "acme@kernel.org" <acme@kernel.org>
Subject: RE: [PATCH V5 4/8] perf/x86/intel/uncore: add new data structures
 for free running counters
Thread-Topic: [PATCH V5 4/8] perf/x86/intel/uncore: add new data structures
 for free running counters
Thread-Index: AQHTjjLMO5E6Fi0JBEaHVwBOA31k86N5HycAgACap6CAAPCdgIAApDaA//+iMICAAI7aIP//eyCAgACGgND//6MogAACbqKAANlSuBA=
Date:   Tue, 23 Jan 2018 22:00:58 +0000
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F07753803C1E@SHSMSX103.ccr.corp.intel.com>
References: <1516042629-387021-4-git-send-email-kan.liang@intel.com>
 <20180118133248.GC2249@hirez.programming.kicks-ass.net>
 <37D7C6CF3E00A74B8858931C1DB2F07753801FEF@SHSMSX103.ccr.corp.intel.com>
 <20180119130731.GQ2228@hirez.programming.kicks-ass.net>
 <37D7C6CF3E00A74B8858931C1DB2F077538025E7@SHSMSX103.ccr.corp.intel.com>
 <20180119171929.GZ2228@hirez.programming.kicks-ass.net>
 <37D7C6CF3E00A74B8858931C1DB2F077538026F3@SHSMSX103.ccr.corp.intel.com>
 <CABPqkBRb5s-RH+bDNebbxDgVFwSNanmo3Q7hEnMB4JQiW4d77A@mail.gmail.com>
 <37D7C6CF3E00A74B8858931C1DB2F07753802712@SHSMSX103.ccr.corp.intel.com>
 <20180119202417.GK7844@tassilo.jf.intel.com>
 <20180119213355.GE2269@hirez.programming.kicks-ass.net>
In-Reply-To: <20180119213355.GE2269@hirez.programming.kicks-ass.net>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Fri, Jan 19, 2018 at 12:24:17PM -0800, Andi Kleen wrote:
> > > Oh, think a bit more.
> > > I think we cannot do the same thing as we did for CPU PMU's fixed
> counters.
> > >
> > > The counters here are free running counters. They cannot be start/stop.
> >
> > Yes free running counter have completely different semantics. They
> > need a separate event code.
> 
> The only thing that matters is if they count the same thing or not.
>

Hi Peter,

There is NO event available on the GPs, that is exactly the same as
the free-running counters.

For example, the BW free-running counters count the requests associated
with writes and completions.
The most similar events on the GPs are DATA_REQ_{OF,BY}_CPU.* events.
Except that some of their sub-events count requests which not completions.
There are also other minor differences.
So we don't have alternative events for the free-running counters.
I think we have to use 0xff.

For details, please refer to the uncore PMU guide. 
https://www.intel.com/content/www/us/en/processors/xeon/scalable/xeon-scalable-uncore-performance-monitoring-manual.html

Thanks,
Kan
 
> The not start/stop thing is not important. See arch/x86/events/msr.c on how
> to deal with that. The short story is that you simply ignore stop and update
> the prev_count on start. Then any next update will increment with the
> correct delta.
> 
> (if the counter is short you also need to run a timer to deal with wraps).