Received: by 10.223.176.46 with SMTP id f43csp63401wra; Tue, 23 Jan 2018 16:11:54 -0800 (PST) X-Google-Smtp-Source: AH8x2261ovoXOTNnt0YZvYFOp5yPozCQ4CXPKHsFjRm0HQxj4NBQUUr5NqTo14Sn2D4+wuOGlyQy X-Received: by 2002:a17:902:6e01:: with SMTP id u1-v6mr6539440plk.12.1516752714641; Tue, 23 Jan 2018 16:11:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516752714; cv=none; d=google.com; s=arc-20160816; b=AtRHx8WY5bKGeU0fh2NcghK8kbWTdKAtDnbskwMV2ZAEjigSc0WIcVmuazLr7nB8gi p4ns9dXzUY3FSEvB6Rs0YTxI2TgKzNmxha+WPL6ZOB+10IWsCtIMn/6fWzAOYMpTK8IS Fo2uqku/VuAOlvNX37nW6Qg4dU9hw6QatVKT3jytAZsW6DBI+pzHcRKJ/kecvh6xGBLk cotGvDx9B2VIwAsWtyfZqSXf70H7L6rh92UU4CfSxVQuaNpY1Ay+ly4K/mWSF3iNt2gg DBac9y56VuU7hv6Ev4WqumBd3yKZr4Zjo5/Ey53MROs3e1cYJWxUg0OyTvU9lWGEuO+w FaPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=57wk/httIQOCOQ6kUa9Wf6NhLctWrg5FUTL1H8p+cGE=; b=WSiogCGIa3F1qotW0BrWkUrhOA9pKhMoScobqyquNOjbCCyN8GzUHjyrzQ3zNy+jEb XThgjZRsViEWpvWRmpiCvg+MMRteegXJ+f5j5rEz2lcRBsEE78uIrnIjNkNkWRZHs9jF goriC+nuFTdZAec6KeZeOdkd6CPVatA6x2uy31/hGhY25FBcU1JcIvuYDS/ed/qIpMKt x+WENxdxYPE3gVfHS8RoqDPZG8QpTwMwbtOjNxXDVRKcjWXAYpXznD30M4w4iYO12aYl jtcTndRXj7pqv4hP1gC4kKKVLw370E9Lc/9indFymAmIprpctciGW0iESqJHkLx5p4xf CnQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fmSpsdWN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w23si15534764pgc.569.2018.01.23.16.11.39; Tue, 23 Jan 2018 16:11:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fmSpsdWN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbeAXALN (ORCPT + 99 others); Tue, 23 Jan 2018 19:11:13 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33044 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbeAXALM (ORCPT ); Tue, 23 Jan 2018 19:11:12 -0500 Received: by mail-pf0-f195.google.com with SMTP id t5so1636985pfi.0 for ; Tue, 23 Jan 2018 16:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=57wk/httIQOCOQ6kUa9Wf6NhLctWrg5FUTL1H8p+cGE=; b=fmSpsdWNqDk+yhzLs1DFzH121W8rvdeKRIJ+Myvp2Rf8ELy/fx0+271baRR05It3/l o3mQhj/TD96m9dnSjJo/UTJnSXgdOcqLV+WyG9/2gs6Bu3SSCoeR/R2vG4r+YHN/tSAB oLXGE/mROLLIJRmxaG4UjWHBjrzIopv3mEgioqljMopiekvHhqTpJ1GR38dP1W1ShZ/O qrbVyIViyPkCJ41XO41cNBaKdE9NmC2wPH0yRq9jXSJ69lW2LZfxM3ZPq6tlNUCvdOsP 2wBMH6R6JrWUQYM80Hz9ZwzSeja8HcJqRSfb3SCSp/eklfMWKJgNeU6GKS16pFUwZP1E cOrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=57wk/httIQOCOQ6kUa9Wf6NhLctWrg5FUTL1H8p+cGE=; b=EyYy41328CY4zCL0Sc1RgJt+tBthdQURW68jeLL6RNIvF7IyKPUPlPGM0QjU6x1g8E y6vaN2zpM4Am4yaxzyd9pqRuUo/Ls+0K7hgRnV3tbJ1md8J2KZqimrunyzW0vX0lazpj GkeMhM0UAlyjsDba0DLjKNdXlQQpcuzgwt+weVVZh2cIUzarmVUMydQUvOHDcWoMYHte SlaUW+J9MJEaZj3JjOYwkGsRL16gOZLU29kscLezDEXtQdh4yhuiQJNm3r+qjPl3Skrd 0YE/fZAqw9yOA3Ss5Y+L6zFlf9xQK+NG8uc5HJvQYHrnlCwVihZb1TFfcLWfdsaNlNBs sMzg== X-Gm-Message-State: AKwxytdSfb/yp67T3ty1KmTmndbzkevdFmfr6ziHSQUEABQEQxBjZvqL viPQqiHAJ0hKBOR4g5lfFLGkXw== X-Received: by 2002:a17:902:8a8a:: with SMTP id p10-v6mr6249521plo.261.1516752671526; Tue, 23 Jan 2018 16:11:11 -0800 (PST) Received: from shreeya-VirtualBox ([103.212.140.128]) by smtp.gmail.com with ESMTPSA id z85sm7010648pfk.110.2018.01.23.16.11.10 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 Jan 2018 16:11:10 -0800 (PST) From: Shreeya Patel To: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Shreeya Patel Subject: [PATCH v4 3/4] Staging: rtl8723bs: Remove dead code Date: Wed, 24 Jan 2018 05:41:07 +0530 Message-Id: <146ccbda981d5def600d20c2c678e280a31a3faf.1516751432.git.shreeya.patel23498@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "oldmem==NULL;" The above bug under the ifdef code would have caused a GCC warning if it were ever compiled. Hence, remove the dead ifdefed code from the file. Signed-off-by: Shreeya Patel --- Changes in v3 -Remove dead code. drivers/staging/rtl8723bs/hal/sdio_ops.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index 997ebc0..cc51969 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -453,21 +453,6 @@ static u32 sdio_read_port( cnt = _RND(cnt, psdio->block_transfer_len); /* cnt = sdio_align_size(cnt); */ - if (oldcnt != cnt) { -#ifdef SDIO_DYNAMIC_ALLOC_MEM - oldmem = mem; - mem = rtw_malloc(cnt); - if (mem == NULL) { - DBG_8192C(KERN_WARNING "%s: allocate memory %d bytes fail!\n", __func__, cnt); - mem = oldmem; - oldmem == NULL; - } -#else - /* in this case, caller should gurante the buffer is big enough */ - /* to receive data after alignment */ -#endif - } - err = _sd_read(intfhdl, addr, cnt, mem); #ifdef SDIO_DYNAMIC_ALLOC_MEM -- 2.7.4