Received: by 10.223.176.46 with SMTP id f43csp273644wra; Tue, 23 Jan 2018 20:48:33 -0800 (PST) X-Google-Smtp-Source: AH8x227pc7QQD9m25u97D2EeMazU1MlVDF3ehhkgTrRWYjrxZCfch9WuXb/VgPZhWQ9nHzN67Hw2 X-Received: by 10.99.96.142 with SMTP id u136mr9991513pgb.406.1516769312938; Tue, 23 Jan 2018 20:48:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516769312; cv=none; d=google.com; s=arc-20160816; b=ZMSsSY60amSGgr0FY/G+4eaIBwqkCYujf8w4/Ppo4xvCRnzmZnG0Hb0csIsHAIOGVd JVGnw8aQeyzfTYQoVAsgGQXgc8LYxVFEHI/QtKk/sZ6uFFNgFUqOvn6jarfW+9gDy/LP NTLnIvkiE1GXkOFuby5cixtqVWGbsYxnji7LhRySo3VFjoo212Gk0WE2sVobn2z6wCn4 JkTHd5ONbih6GX7YX4ZJFAtCWLQDt4fMlSKEaPkGu15jK3z/e2MK99dYJJDqrIkXN9YW /aOObVdhVgYoyvTumAU1Ra8qGoXVKuJ1pWIiWn5X6X1m6Rc65B7qoq7akWfPLAStYuQk AS7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=3r3ot+UEDwf4B9JY/7pkPikAtyf8lusuYXSE47c8n00=; b=hyFITkUjjdITZo2mfQ5W4OXGyUw0/e2RxuRMErkb8Cgsl2XsntHWulDy4DZ/6JiY4+ GQYIepxqDzf1xWw6m7o7Ght68s7AKlCb2lrnydh4LKrljPuFlpwjfV7HUaoiLDgfJSmA SQxcELlKKAeJDn+v+DMSg/iaMxpBBUTt+OnlwOkhvYisPd2nKHN6o+UU9QrJJIGWECGE kZMq2p3luTKNDgAYe1wLAe6eMWRgYDgNsnsYm3y4pf8TQxQK4vpERmZ3zlSQy7V3buvt gijBWJZjwImBdJU7H8AOYBA8cmsbiGT46AqBKM1HsElx1Jip5ZUgjUYqJWuQKCkkbwjc CKqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=KvdeYUwt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w10-v6si5548773plz.107.2018.01.23.20.48.18; Tue, 23 Jan 2018 20:48:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=KvdeYUwt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932743AbeAXErY (ORCPT + 99 others); Tue, 23 Jan 2018 23:47:24 -0500 Received: from mail-by2nam03on0117.outbound.protection.outlook.com ([104.47.42.117]:41259 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932535AbeAXEQL (ORCPT ); Tue, 23 Jan 2018 23:16:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3r3ot+UEDwf4B9JY/7pkPikAtyf8lusuYXSE47c8n00=; b=KvdeYUwteBBdOEoJeFar0eXjXd8XdEePVdM+wJFjKeGh4l/cX8Ol6wzN8fcrbYqpj0jvFdnmsYQMF4URcHBzK/5G3hknKnmI1rn5WAHv3fnqtlb/fyfFcSZMCK7SoiJAWixXCl+uHjQRDDJ8aZE+tPW0my+Lij69m4i16mN6cWE= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1078.namprd21.prod.outlook.com (52.132.130.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.464.1; Wed, 24 Jan 2018 04:16:04 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::6485:b98:d15e:9da7]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::6485:b98:d15e:9da7%2]) with mapi id 15.20.0464.000; Wed, 24 Jan 2018 04:16:04 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Christophe JAILLET , Tomi Valkeinen , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 086/100] drm/omap: Fix error handling path in 'omap_dmm_probe()' Thread-Topic: [PATCH AUTOSEL for 4.14 086/100] drm/omap: Fix error handling path in 'omap_dmm_probe()' Thread-Index: AQHTlMnsISP4IRInTkylxSAS2SKa6A== Date: Wed, 24 Jan 2018 04:15:09 +0000 Message-ID: <20180124041414.32065-86-alexander.levin@microsoft.com> References: <20180124041414.32065-1-alexander.levin@microsoft.com> In-Reply-To: <20180124041414.32065-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1078;7:AphfICdLBQpn1w8GFhqmMz2iZhphDrqVoPffKktX2lv8awP9a1//F0/liLs2jqnmu9aNlOeCDOcZMlyfHhq5snD/vNo/U5+TaJGofVnLr+wmXJL6xeI8y9TGCg9zRNRQ0wpVor9+WluZetHCFcZsY+PEuAqPSiECbetVf/MA7Hfo0ojy5MKacze0So1m7+xdoEvHtFWPa76s7SvBb+3MPEl9y+LXIwUm9SncPQGtZSvxtcM3csJJAc0+U+wj7A9O x-ms-office365-filtering-correlation-id: 9b9282b4-fec7-4423-b24d-08d562e12f56 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB1078; x-ms-traffictypediagnostic: DM5PR2101MB1078: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(31051911155226)(89211679590171)(155761271638844); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231046)(2400081)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB1078;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1078; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(39860400002)(366004)(396003)(39380400002)(199004)(189003)(86612001)(22452003)(6436002)(106356001)(107886003)(102836004)(105586002)(305945005)(5250100002)(2501003)(14454004)(3280700002)(4326008)(7736002)(97736004)(59450400001)(6512007)(36756003)(8936002)(2950100002)(3846002)(6116002)(6506007)(86362001)(54906003)(76176011)(110136005)(2906002)(53936002)(66066001)(72206003)(6346003)(5660300001)(8676002)(478600001)(10290500003)(68736007)(81156014)(10090500001)(1076002)(3660700001)(25786009)(316002)(2900100001)(99286004)(575784001)(26005)(6486002)(81166006)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1078;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: TTExWUHYfNztg4hB7jdgcxOK8oBIL/8iGUSsx8IMy+EDAQK+yWoGBjoiAo5jS6WzMMrItUVyJ5eX9Lvq6snptw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b9282b4-fec7-4423-b24d-08d562e12f56 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 04:15:09.8710 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1078 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 8677b1ac2db021ab30bb1fa34f1e56ebe0051ec3 ] If we don't find a matching device node, we must free the memory allocated in 'omap_dmm' a few lines above. Fixes: 7cb0d6c17b96 ("drm/omap: fix TILER on OMAP5") Signed-off-by: Christophe JAILLET Signed-off-by: Tomi Valkeinen Signed-off-by: Sasha Levin --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/oma= pdrm/omap_dmm_tiler.c index 1dd3dafc59af..c60a85e82c6d 100644 --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c @@ -638,7 +638,8 @@ static int omap_dmm_probe(struct platform_device *dev) match =3D of_match_node(dmm_of_match, dev->dev.of_node); if (!match) { dev_err(&dev->dev, "failed to find matching device node\n"); - return -ENODEV; + ret =3D -ENODEV; + goto fail; } =20 omap_dmm->plat_data =3D match->data; --=20 2.11.0