Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <2205915.z0ubSpqczI@avalon>
References: <20180122102608.12565-1-philippe.cornu@st.com> <3169703.7pajs7FEnH@avalon>
 <2bf185e2-9b02-3632-dc9a-baf8f4109b44@st.com> <2205915.z0ubSpqczI@avalon>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Wed, 24 Jan 2018 09:57:30 +0100
Message-ID: <CA+M3ks4kCpcNfd1NyVLDtPOKmDniteXw2-iUqUikeicRdRAa6A@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Philippe Ombredanne <pombredanne@nexb.com>
Cc:     Philippe CORNU <philippe.cornu@st.com>,
        Archit Taneja <architt@codeaurora.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        David Airlie <airlied@linux.ie>,
        Brian Norris <briannorris@chromium.org>,
        Bhumika Goyal <bhumirks@gmail.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sandy Huang <hjc@rock-chips.com>,
        Heiko Stubner <heiko@sntech.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-rockchip@lists.infradead.org" 
        <linux-rockchip@lists.infradead.org>,
        Yannick FERTRE <yannick.fertre@st.com>,
        Vincent ABRIOU <vincent.abriou@st.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Ludovic BARRE <ludovic.barre@st.com>,
        Mickael REULIER <mickael.reulier@st.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-01-24 0:32 GMT+01:00 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> Hi Philippe,
>
> On Tuesday, 23 January 2018 12:25:51 EET Philippe CORNU wrote:
>> On 01/23/2018 12:30 AM, Laurent Pinchart wrote:
>> > On Monday, 22 January 2018 12:26:08 EET Philippe Cornu wrote:
>> >> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI
>> >> host controller driver.
>> >>
>> >> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
>> >> ---
>> >>
>> >>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +-----
>> >>   1 file changed, 1 insertion(+), 5 deletions(-)
>> >>
>> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> >> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index
>> >> 46b0e73404d1..e06836dec77c 100644
>> >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> >> @@ -1,12 +1,8 @@
>> >> +// SPDX-License-Identifier: GPL-2.0
>> >
>> > According to Documentation/process/license-rules.txt this would change
>> > the existing license. The correct identifier is GPL-2.0+.
>>
>> You are right, I did not put the correct identifier :(
>>
>> After reading more spdx.org, I wonder if the correct value should be
>> GPL-2.0-or-later instead of GPL-2.0+
>>
>> https://spdx.org/licenses/GPL-2.0-or-later.html
>> https://spdx.org/licenses/GPL-2.0+.html
>>
>> What is your opinion?
>
> I agree in principle, and I've even asked for that before, but I've been told
> that we should stick to the license identifiers defined in Documentation/
> process/license-rules.txt. The file might get updated to use GPL-2.0-or-later
> and GPL-2.0-only later, and kernel sources will likely then get patched in one
> go.

+ Philippe O. to check what I'm writing just below.

In -next branch I only see reference to GPL-2.0+ identifier so for me
it fine to use it here.
Is that right ? or should we use GPL-2.0-or-later keyword ?

Benjamin

>
>> >>  /*
>> >>   * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd
>> >>   * Copyright (C) STMicroelectronics SA 2017
>> >>   *
>> >> - * This program is free software; you can redistribute it and/or modify
>> >> - * it under the terms of the GNU General Public License as published by
>> >> - * the Free Software Foundation; either version 2 of the License, or
>> >> - * (at your option) any later version.
>> >> - *
>> >>   * Modified by Philippe Cornu <philippe.cornu@st.com>
>> >>   * This generic Synopsys DesignWare MIPI DSI host driver is based on the
>> >>   * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.
>
> --
> Regards,
>
> Laurent Pinchart