Received: by 10.223.176.46 with SMTP id f43csp728705wra; Wed, 24 Jan 2018 05:09:19 -0800 (PST) X-Google-Smtp-Source: AH8x224DJBuPX/f3oVp7lO2JIsDAdwyn5LcUgibc++TdIgvoJn1Yh4b84GGiEgJf47Pu6jw3sfkU X-Received: by 10.98.85.195 with SMTP id j186mr8363505pfb.77.1516799359328; Wed, 24 Jan 2018 05:09:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516799359; cv=none; d=google.com; s=arc-20160816; b=enEE7iT2mfHv/0AG36gxVrr0g/ymdIj8IrsAgfSfm8W3O2q4lZ/wumNd28ul4WMBFr fitROcjr+rHcoYG6ewNoJQtPUQpc32wVqTUz5Dou/EPfkUXXqlTYCXiPJL1wHQ5dd/Sy ibUF3SumJYeAMPhbaCifJwBAJDQghGhCKOd56flvzv6hoPKpezJ0LT18OOmxMqoS+K+R Vs3Qva0iwjDgEEyqeNG/tCSiw+HywwRAi/IsU+XVn1F2p/E4Mq/n72lTi+zrUYsfLWVL +kNXNm3weHKBfSYumbSogpzVjlu6MSQBS9KspwH5/0HOiBuFUt9cyvSr/NNsq5a7OJTY z1QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=et7wZWFTQopOGy+aAI41mFdBaQZ4KzbrgTsPRpmI7Uw=; b=Mwr2rjPwLnPtE3gI3TfdZxndNFXGlYOdOFg+RR3InKefumMj+QgPbu65kBH3DSZ7hg u+DFW/MGeQHPSyEZM2NyePYN6D0KTmemewDpGLGp1XvCw2CTDW/Gkfu+ZjCBnsoQfhq0 FwrwezJRZhxx1vyl7h+vYryZXqaE+o6U2gqKKB341akmGdqjw201eIadHihC1PiLt7i2 sk1tzqY1zvNkxx4WGvqKimzY4dtR9XnptAfyALj29IBaocsEbpwZL5/Yd20xI3NHbVbV Z1CBy4TKxTYIby4hHqM9hamOQU6i7yf+TdY2hYqq8w21I3S/oerBDfzVcB8H0elvflMF yxwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@jamieiles-com.20150623.gappssmtp.com header.s=20150623 header.b=ISugK4J+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f80si2865374pfa.111.2018.01.24.05.09.05; Wed, 24 Jan 2018 05:09:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@jamieiles-com.20150623.gappssmtp.com header.s=20150623 header.b=ISugK4J+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933672AbeAXNI3 (ORCPT + 99 others); Wed, 24 Jan 2018 08:08:29 -0500 Received: from mail-wr0-f176.google.com ([209.85.128.176]:41591 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933633AbeAXNI1 (ORCPT ); Wed, 24 Jan 2018 08:08:27 -0500 Received: by mail-wr0-f176.google.com with SMTP id v15so3961994wrb.8 for ; Wed, 24 Jan 2018 05:08:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jamieiles-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=et7wZWFTQopOGy+aAI41mFdBaQZ4KzbrgTsPRpmI7Uw=; b=ISugK4J+wY5urO0ki0wOhYLoDPNeGqlUgGDeC43IYY38MsO8oPjMphePfFUjqOO+0T mI3w4Bl5AkOHANqrKt223Ml5wSH6mzx6F3+pch6HLjSn0dcw3XKEjh9z0YiSaz+hU33a f5O9Ah3mH4rWu1IywwPt7pPF3WgkVwYv7QFuZeRxrOWBMYcfq2kRNWnKm79SL9fDYq28 JgDcMOskFU0PLMlQwRj3vv6dQeFg+eO6DGNNDjQDX2tpgNpQv7S6eSdsrvrovAtyUi+r EIf391FZsUCHngjlQxFCnfA6dleiFquOOtQbKF0FK63VbP0v+rQnU6Gfr9Q3LtupuGCt KEkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=et7wZWFTQopOGy+aAI41mFdBaQZ4KzbrgTsPRpmI7Uw=; b=mOZJKD2JtchFQhjeGHmbLV1/DawdEyr/aNGZ8GiVtSHx68qc7ZC5dAEvLkAxV7Tj+5 NtpnpbrDmm5/6gdGac8Xb4YonrnG8XfJdNmEQpnQpmK5zmfcHq16z1OpX0Ea5TFFa3lx v2hr35EPkyUZ8sv4NsOjEkq9OPsL/HUoKJzRzC8lBoDp0CbEbths/RFxCj3HyQweIZ1V 9oLnCSnclGQdbI1tiYai1C7HjMknz05EPOMCb3Aat8WDB26gnPH2KlYBmEvTmBsn2WWb 0niq/YEZ8iEqMG4JSZFS4JrsKJgYUU4Brv8fh9EQ7qawMs9qUxvcVRkA1iqn0jhb3oHn EDUQ== X-Gm-Message-State: AKwxytcoNKXWll1C8n1ZKpJZsGPhmErcCEfgdvreslKhSFy/lyY/xxWu TwjNcV+nsgpKtyZKK1X2F61SKA== X-Received: by 10.223.184.134 with SMTP id i6mr5769727wrf.169.1516799306483; Wed, 24 Jan 2018 05:08:26 -0800 (PST) Received: from localhost (cpc128704-hawk17-2-0-cust94.know.cable.virginm.net. [82.38.213.95]) by smtp.gmail.com with ESMTPSA id f13sm1811675wre.84.2018.01.24.05.08.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 05:08:25 -0800 (PST) Date: Wed, 24 Jan 2018 13:08:25 +0000 From: Jamie Iles To: Alexey Khoroshilov Cc: Jamie Iles , Javier Martinez Canillas , Herbert Xu , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe() Message-ID: <20180124130825.tjcywfbcdfikklfl@willow> References: <1516398795-9018-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516398795-9018-1-git-send-email-khoroshilov@ispras.ru> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Alexey! On Sat, Jan 20, 2018 at 12:53:15AM +0300, Alexey Khoroshilov wrote: > If clk_get() fails, device_remove_file() looks inappropriate. > > The error path, where all crypto_register fail, misses resource > deallocations. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Reviewed-by: Jamie Iles