Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kernel: x86: tboot: Replace mdelay with usleep_range in
 tboot_wait_for_aps
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     ning.sun@intel.com, mingo@redhat.com, hpa@zytor.com,
        x86@kernel.org, tboot-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <1516759102-17549-1-git-send-email-baijiaju1990@gmail.com>
 <alpine.DEB.2.20.1801241246350.1997@nanos>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Message-ID: <fc5e01ed-e360-5d48-01ea-dbcafb6cf7f9@gmail.com>
Date:   Wed, 24 Jan 2018 21:37:46 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1801241246350.1997@nanos>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2018/1/24 19:47, Thomas Gleixner wrote:
> On Wed, 24 Jan 2018, Jia-Ju Bai wrote:
>
>> The function tboot_wait_for_aps is not called in atomic context.
>> Thus mdelay can be replaced with usleep_range, to reduce busy wait.
> And how did you establish that it's not called in atomic context?
>
> Thanks,
>
> 	tglx

It is reported by a static analysis tool written by myself.
This tool finds that mdelay in tboot_wait_for_aps is not called by 
holding a spinlock or in an interrupt handler, thus mdelay can be replaced.


Thanks,
Jia-Ju Bai