Received: by 10.223.176.46 with SMTP id f43csp822186wra; Wed, 24 Jan 2018 06:30:34 -0800 (PST) X-Google-Smtp-Source: AH8x227mG/l8n7za3rgDDYqY9lIcNFJWD0qWcpOd15Jb1Yc/+Ne19hqWZNaTheOtcwWJTJf+gp+L X-Received: by 10.98.69.209 with SMTP id n78mr13349635pfi.6.1516804234884; Wed, 24 Jan 2018 06:30:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516804234; cv=none; d=google.com; s=arc-20160816; b=i1k1yngMAMWhgtDpcSqYCLq13ml+OTiR/VAqy7Jl7gryRZ8wFqjkCXkXTAEqyzeEFc qRA/ZFZHUrXKUaFkjKv6wRAwCqGN8IC1Bh0GE+bJgpM+wwotX16dJvI52xyQ48edlgaV QgTLJ7DENulkwn5wwhjlKiAnkB2dXKYTUSDpb/Ujldm0RXWRR/TLBRC1raKwZoMUxno8 plbqIy7gFT+N50INfSWDjznL4fPLOp/0j+JVf1+cFTkFZ8n8v1oPjXkwFOZyRje7nH65 G5h87GEIr35DKRxV8ZnZNCP6bzhSVa+pLx4vVsSFRfcPIjYlJppbZtKSmou0gG8N14r2 nKLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=F95rTJYtAqzI16bz7YcqpHNFk7DsLv1RfsL73BRjAyQ=; b=ozz+0UGt0xqDFJT1cLYaMMAA4LzDjBUej8K1ykzTIkeNdb5CCgKXPTSnwKOy7lG7zF CRLWJdiNJTawN14LQVugNPqjNHBDD7LHz2nZtoCCt9xKiI9iAFNp67k0jdd+EiC4gUP7 G6sI3V94k6N2OQatAiqKuSig5ku67/W/2Qb+KhTfdTRiG/UUX5qboMrAj+qVt8ZRGcmK vJdEGEVtAcsvEW+4aIDWCY+Ld+hPQ/1kcy+aLJ1akDcXKj70K4ifRNgVictmq6EvKdkB /o5W6+9Jl3B+C6ar+YRolspWxBU1fjksN1M31a1EgMc/0T1PueYnK70mgzZnXM5zhYMH mMXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o4si198286pgf.828.2018.01.24.06.30.20; Wed, 24 Jan 2018 06:30:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933942AbeAXO34 (ORCPT + 99 others); Wed, 24 Jan 2018 09:29:56 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933723AbeAXO3z (ORCPT ); Wed, 24 Jan 2018 09:29:55 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 2CEE7108B; Wed, 24 Jan 2018 14:29:55 +0000 (UTC) Date: Wed, 24 Jan 2018 15:29:54 +0100 From: Greg Kroah-Hartman To: Dmitry Eremin Cc: devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH v3] staging: lustre: separate a connection destroy from free struct kib_conn Message-ID: <20180124142954.GA4658@kroah.com> References: <20180122103924.GB23996@kroah.com> <1516803252-14266-1-git-send-email-dmitry.eremin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516803252-14266-1-git-send-email-dmitry.eremin@intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 24, 2018 at 05:14:12PM +0300, Dmitry Eremin wrote: > Rewrite the logic of the original commit 4d99b2581eff ("staging: lustre: avoid > intensive reconnecting for ko2iblnd") and move the freeing a struct kib_conn > outside of the function kiblnd_destroy_conn(). The freeing of struct kib_conn > should be depending on the second argument free_conn of function > kiblnd_destroy_conn(struct kib_conn *conn, bool free_conn). If it true the > structure should be freed. > > Fixes: 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") > Signed-off-by: Dmitry Eremin > --- > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 7 +++---- > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 2 +- > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 6 ++++-- > 3 files changed, 8 insertions(+), 7 deletions(-) What changed from version 2 and 1? Always included that below the --- line please. 4th try is a charm? :) thanks, greg k-h