Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Jan 2018 22:29:45 +0100
From:   Ingo Molnar <mingo@kernel.org>
To:     Greg KH <gregkh@linux-foundation.org>
Cc:     David Woodhouse <dwmw@amazon.co.uk>, arjan@linux.intel.com,
        tglx@linutronix.de, karahmed@amazon.de, x86@kernel.org,
        linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com,
        bp@alien8.de, peterz@infradead.org, pbonzini@redhat.com,
        ak@linux.intel.com, torvalds@linux-foundation.org,
        dave.hansen@intel.com, gnomes@lxorguk.ukuu.org.uk
Subject: Re: [PATCH v3 6/6] x86/cpufeature: Blacklist SPEC_CTRL on early
 Spectre v2 microcodes
Message-ID: <20180124212945.ikfzxdxah2shqiis@gmail.com>
References: <1516813025-10794-1-git-send-email-dwmw@amazon.co.uk>
 <1516813025-10794-7-git-send-email-dwmw@amazon.co.uk>
 <20180124172931.GG16646@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180124172931.GG16646@kroah.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Wed, Jan 24, 2018 at 04:57:05PM +0000, David Woodhouse wrote:

> > +static const struct sku_microcode spectre_bad_microcodes[] = {
> > +	{ INTEL_FAM6_KABYLAKE_DESKTOP, 0x0B, 0x80 },
> > +	/* Corrected typo in Intel doc */
> > +	{ INTEL_FAM6_KABYLAKE_DESKTOP, 0x0A, 0x80 },
> > +	{ INTEL_FAM6_KABYLAKE_MOBILE, 0x0A, 0x80 },
> > +	{ INTEL_FAM6_KABYLAKE_MOBILE, 0x09, 0x80 },
> > +	{ INTEL_FAM6_KABYLAKE_DESKTOP, 0x09, 0x80 },
> > +	{ INTEL_FAM6_SKYLAKE_X, 0x04, 0x0200003C },
> > +	{ INTEL_FAM6_SKYLAKE_MOBILE, 0x03, 0x000000C2 },
> > +	{ INTEL_FAM6_SKYLAKE_DESKTOP, 0x03, 0x000000C2 },
> > +	{ INTEL_FAM6_BROADWELL_CORE, 0x04, 0x28 },
> > +	{ INTEL_FAM6_BROADWELL_GT3E, 0x01, 0x0000001B },
> > +	{ INTEL_FAM6_HASWELL_ULT, 0x01, 0x21 },
> > +	{ INTEL_FAM6_HASWELL_GT3E, 0x01, 0x18 },
> > +	{ INTEL_FAM6_HASWELL_CORE, 0x03, 0x23 },
> > +	{ INTEL_FAM6_IVYBRIDGE_X, 0x04, 0x42a },
> > +	{ INTEL_FAM6_HASWELL_X, 0x02, 0x3b },
> > +	{ INTEL_FAM6_HASWELL_X, 0x04, 0x10 },
> > +	{ INTEL_FAM6_HASWELL_CORE, 0x03, 0x23 },
> > +	{ INTEL_FAM6_BROADWELL_XEON_D, 0x02, 0x14 },
> > +	{ INTEL_FAM6_BROADWELL_XEON_D, 0x03, 0x7000011 },
> > +	{ INTEL_FAM6_BROADWELL_GT3E, 0x01, 0x0000001B },
> > +	{ INTEL_FAM6_BROADWELL_X, 0x01, 0x0b000025 },
> > +	/* Dropped repeat of KBL Desktop 906E9, 0x80 */
> > +	{ INTEL_FAM6_SKYLAKE_X, 0x03, 0x0100013e },
> > +	/* Dropped repeat of SKX 50654, 0x200003c */

Could we please also get better tabulation of this array, so that the general 
layout of the values is easier to see? It's also prettier:

	{ INTEL_FAM6_KABYLAKE_DESKTOP,		0x09, 0x00000080 },
	{ INTEL_FAM6_SKYLAKE_X,			0x04, 0x0200003C },
	{ INTEL_FAM6_SKYLAKE_MOBILE,		0x03, 0x000000C2 },
	{ INTEL_FAM6_SKYLAKE_DESKTOP,		0x03, 0x000000C2 },

Note the vertical spacing and the fixed length of each column.

(We can ignore the col80 for things like this.)

Thanks,

	Ingo