Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jolly Shah <JOLLYS@xilinx.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
        "mingo@kernel.org" <mingo@kernel.org>,
        "matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
        "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Rajan Vaja <RAJANV@xilinx.com>
Subject: RE: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmware
 driver
Thread-Topic: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmware
 driver
Thread-Index: AQHTj9C5tJkts91Bqkm+RPr8yx5ad6OBK22AgAKKrYA=
Date:   Wed, 24 Jan 2018 23:28:12 +0000
Message-ID: <DM2PR0201MB076771C6652E5D19A803D66DB8E20@DM2PR0201MB0767.namprd02.prod.outlook.com>
References: <1516220434-22204-1-git-send-email-jollys@xilinx.com>
 <1516220434-22204-3-git-send-email-jollys@xilinx.com>
 <20180123083823.GB21463@kroah.com>
In-Reply-To: <20180123083823.GB21463@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c446e5d8-a65d-4139-9307-08d56382230a
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 23:28:12.5711
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0992
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for review Greg,

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, January 23, 2018 12:38 AM
> To: Jolly Shah <JOLLYS@xilinx.com>
> Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; matt@codeblueprint.co.uk=
;
> sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org;
> dmitry.torokhov@gmail.com; michal.simek@xilinx.com; robh+dt@kernel.org;
> mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; Rajan Vaja
> <RAJANV@xilinx.com>; Jolly Shah <JOLLYS@xilinx.com>
> Subject: Re: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmwar=
e
> driver
>=20
> On Wed, Jan 17, 2018 at 12:20:32PM -0800, Jolly Shah wrote:
> > This patch is adding communication layer with firmware.
> > Firmware driver provides an interface to firmware APIs.
> > Interface APIs can be used by any driver to communicate to
> > PMUFW(Platform Management Unit). All requests go through ATF.
> >
> > Signed-off-by: Jolly Shah <jollys@xilinx.com>
> > Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> > ---
> >  arch/arm64/Kconfig.platforms                    |   1 +
> >  drivers/firmware/Kconfig                        |   1 +
> >  drivers/firmware/Makefile                       |   1 +
> >  drivers/firmware/xilinx/Kconfig                 |   4 +
> >  drivers/firmware/xilinx/Makefile                |   4 +
> >  drivers/firmware/xilinx/zynqmp/Kconfig          |  16 +
> >  drivers/firmware/xilinx/zynqmp/Makefile         |   4 +
> >  drivers/firmware/xilinx/zynqmp/firmware.c       | 987
> ++++++++++++++++++++++++
> >  include/linux/firmware/xilinx/zynqmp/firmware.h | 570 ++++++++++++++
>=20
> Why does this file need to be in include/linux/ at all?  Shouldn't it jus=
t live in the
> driver-specific subdir?
>=20
> thanks,
>=20
> greg k-h

It is used by multiple drivers so can not live in driver specific subdir.

Thanks,
Jolly Shah