Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAHRSSEwmo8J4swiZWb4U_-TR7DNea1FGpVMx6gZpCf24Lmx4Dg@mail.gmail.com>
References: <1515552545-18311-1-git-send-email-opensource.ganesh@gmail.com>
 <20180122155428.GB7714@kroah.com> <CAHRSSEwmo8J4swiZWb4U_-TR7DNea1FGpVMx6gZpCf24Lmx4Dg@mail.gmail.com>
From:   Ganesh Mahendran <opensource.ganesh@gmail.com>
Date:   Thu, 25 Jan 2018 10:06:41 +0800
Message-ID: <CADAEsF-Tq+a4=mXvXiAWfhsdCCmx_rkuXgsa_gg5AGJ5PGWhmA@mail.gmail.com>
Subject: Re: [PATCH v3] android: binder: use VM_ALLOC to get vm area
To:     Todd Kjos <tkjos@google.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Martijn Coenen <maco@android.com>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Todd:

2018-01-23 1:02 GMT+08:00 Todd Kjos <tkjos@google.com>:
> On Mon, Jan 22, 2018 at 7:54 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Wed, Jan 10, 2018 at 10:49:05AM +0800, Ganesh Mahendran wrote:
>>> VM_IOREMAP is used to access hardware through a mechanism called
>>> I/O mapped memory. Android binder is a IPC machanism which will
>>> not access I/O memory.
>>>
>>> And VM_IOREMAP has alignment requiement which may not needed in
>>> binder.
>>>     __get_vm_area_node()
>>>     {
>>>     ...
>>>         if (flags & VM_IOREMAP)
>>>             align = 1ul << clamp_t(int, fls_long(size),
>>>                PAGE_SHIFT, IOREMAP_MAX_ORDER);
>>>     ...
>>>     }
>>>
>>> This patch will save some kernel vm area, especially for 32bit os.
>>>
>>> In 32bit OS, kernel vm area is only 240MB. We may got below
>>> error when launching a app:
>>>
>>> <3>[ 4482.440053] binder_alloc: binder_alloc_mmap_handler: 15728 8ce67000-8cf65000 get_vm_area failed -12
>>> <3>[ 4483.218817] binder_alloc: binder_alloc_mmap_handler: 15745 8ce67000-8cf65000 get_vm_area failed -12
>>>
>>> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
>>> ----
>>> V3: update comments
>>> V2: update comments
>>> ---
>>>  drivers/android/binder_alloc.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Martijn and Todd, any objections to this patch?
>
> Looks fine to me. Arve, do you remember the rationale for using VM_IOREMAP?

Thanks for your review.

>
>>
>> thanks,
>>
>> greg k-h