Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180125011622.GA7642@visor>
References: <20180125011622.GA7642@visor>
From:   Kees Cook <keescook@chromium.org>
Date:   Thu, 25 Jan 2018 13:35:03 +1100
Message-ID: <CAGXu5j+MR-Juf15V19CmRNVu34a-B8O8XVeERjJBVxFZsAOWmA@mail.gmail.com>
Subject: Re: [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN
To:     Ivan Delalande <colona@arista.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 25, 2018 at 12:16 PM, Ivan Delalande <colona@arista.com> wrote:
> Function handle_IRQ_event was retired in v2.6.39 and replaced with
> handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has
> been broken for a while.

Excellent, thanks for the fix!

Acked-by: Kees Cook <keescook@chromium.org>

Greg, I don't have any other exclusive lkdtm updates, so please feel
free to apply this to misc-next.

Thanks!

-Kees

>
> Fixes: 33b054b867b8 ("genirq: Remove handle_IRQ_event")
> Signed-off-by: Travis Brown <travisb@arista.com>
> Signed-off-by: Ivan Delalande <colona@arista.com>
> ---
>  drivers/misc/lkdtm_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
> index ba92291508dc..4942da93d066 100644
> --- a/drivers/misc/lkdtm_core.c
> +++ b/drivers/misc/lkdtm_core.c
> @@ -96,7 +96,7 @@ static struct crashpoint crashpoints[] = {
>         CRASHPOINT("DIRECT",             NULL),
>  #ifdef CONFIG_KPROBES
>         CRASHPOINT("INT_HARDWARE_ENTRY", "do_IRQ"),
> -       CRASHPOINT("INT_HW_IRQ_EN",      "handle_IRQ_event"),
> +       CRASHPOINT("INT_HW_IRQ_EN",      "handle_irq_event"),
>         CRASHPOINT("INT_TASKLET_ENTRY",  "tasklet_action"),
>         CRASHPOINT("FS_DEVRW",           "ll_rw_block"),
>         CRASHPOINT("MEM_SWAPOUT",        "shrink_inactive_list"),
> --
> 2.16.1


-- 
Kees Cook
Pixel Security