Received: by 10.223.176.46 with SMTP id f43csp1566072wra; Wed, 24 Jan 2018 19:35:17 -0800 (PST) X-Google-Smtp-Source: AH8x225TBapC5WyWk+0D1SQlAfP9FkJT/nrr7Wcvvai1TV6/VDc8Jx/yzk58lY5AAqAhxba4j/gu X-Received: by 2002:a17:902:223:: with SMTP id 32-v6mr10264869plc.77.1516851317245; Wed, 24 Jan 2018 19:35:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516851317; cv=none; d=google.com; s=arc-20160816; b=Q1Dh/o5X8P20MsTtmSw6808RnY9kJy36fNTsYci4rX2rBpKzoCUe1cCxOaiV2VIT6T ljxgVzGomhWUG6mVmgpi5em3HxxmQRS0D2pWZEYZqxWHyqxPhoeyjfrQWr/xK7uaOGoN QWrRay0k1z+laty9G45yJuOYYgP8mlflTbPn2uWZkbChSTTPNqoSavTlBvu6Hl4Flv3E znPRO9n5/z4T0auJ/d5Ek2iSIAS45CcZL5sVqKJNDo5P6qK9Igx+lDtotQGfjMO1SBux FODteTbgJHD24LyjEIuttU8Fau+FGdUmbr1QlSC5DOF4ZaBgxegQm2bcYRESFBYUL/mY jKHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=Cq7eH3QY23DqpcDxvOhwDIk6/G9S6rLQNo+Coklv7Uk=; b=DcWz1J4NbmDceKN9lgoYkpPt/7utahxIFBIQ1utl0IFScxzMJx7D0EZe47FF1256rK CUrI+lVnhca3nrT5Pb/s85iqm7iEA5FigqufrRru6bFfO+3Y0SIqgFBbZOMByOW6kECm Wzg3D27lp8hYS6rclRHM1ue3i6CBIUNvdidlC3rYkzOk6J/bXh9cHBqgx4T4RrsejvBS IVBnvIBuCahFzP8oOBP1wA/59sPIKXQHWl2GOJgbunUOA6AUSi6mmUgcTEVfZqeTfNeH sZ/MdyE2jOOl/q+lhtqSfQhhQeDzmhpGeygHWIvKCKR+eOz7MWhUSFwudM30OMqra0YA zWHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ut4rBkjP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e2-v6si1224358pls.652.2018.01.24.19.35.03; Wed, 24 Jan 2018 19:35:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ut4rBkjP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933287AbeAYDeQ (ORCPT + 99 others); Wed, 24 Jan 2018 22:34:16 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33818 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932956AbeAYDeP (ORCPT ); Wed, 24 Jan 2018 22:34:15 -0500 Received: by mail-pg0-f66.google.com with SMTP id r19so4224342pgn.1; Wed, 24 Jan 2018 19:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Cq7eH3QY23DqpcDxvOhwDIk6/G9S6rLQNo+Coklv7Uk=; b=ut4rBkjPyhT7rOxAyNDl0LQlof72MbAsnQkqzCHwbrKwqwABZfL1js1fMKWYdyrmJH IRiBlBFw2CzI4AL+66rNXkmmXUj4ufQl6z/H8jDVA3KgCi+wHcp2+be0BOUZY//0YP/z xgWd4fIRKuUaYPdG+S1rrO0i/ElFBRnOey+ja/0eVgJCiH1YqcZmTN6ms15LBHlI2aX8 VWjY4rwPks01y5jNlhVlmtWv1sqB/Ap/rKdkbX64kPTMffhAaaMM4EOAJV4brJh+7l8y QHyD8WMD2qohatew39dqEoA27yfZSIKJGCJNw/S3hSHEQqSetThXryuYA0Y7ov7YRZ+8 6awA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Cq7eH3QY23DqpcDxvOhwDIk6/G9S6rLQNo+Coklv7Uk=; b=Hgt6FGju00YcEmPpwxAK+XVoZ1AM5sKIK/mwTcWxAyAC7qi7OiV8eM9vjOHhTpInhQ czwrgHjUlLINwoI5k4ZIyolaZkaVI6wrbqiFSCtHjmNOylkNjKKXlAn/1nG/LkSagKgI BHXb847yJuAtezpZFA6/IzluuuIPpx6eGaEaFFIpUHf2ILYReS5hFOuwjFwh7T/1tYdT D0HQHgiPzhCSBguziEZSU85DiUQDF8mIhN1dbVWRYPo3ywgOM6iQbMy3XHsNs8aksd5c yN4vExcw58S1wrIW2332EweO2RdSYkmqfxdutCXhFq24eRgFEuL06VnblwkWnhnhkgZ2 pkKg== X-Gm-Message-State: AKwxytcl+7jSv2oGtGn7lfTFMyIDD2lXz0qoiUjn/6thzVADCk8sixFK SR1Dnlos0SOSFXjB+CTs6mUpXA== X-Received: by 2002:a17:902:7009:: with SMTP id y9-v6mr1360894plk.138.1516851254619; Wed, 24 Jan 2018 19:34:14 -0800 (PST) Received: from bai-oslab.tsinghua.edu.cn ([2402:f000:1:4413:af:5698:7220:1b27]) by smtp.gmail.com with ESMTPSA id v43sm2375403pgn.30.2018.01.24.19.34.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2018 19:34:14 -0800 (PST) From: Jia-Ju Bai To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH 1/2] block: blk-tag: Replace GFP_ATOMIC with GFP_KERNEL in __blk_queue_init_tags Date: Thu, 25 Jan 2018 11:38:45 +0800 Message-Id: <1516851525-6828-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After checking all possible call chains to kmalloc here, my tool finds that kmalloc is never called in atomic context. Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- block/blk-tag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-tag.c b/block/blk-tag.c index 09f19c6..84db7f663 100644 --- a/block/blk-tag.c +++ b/block/blk-tag.c @@ -124,7 +124,7 @@ static struct blk_queue_tag *__blk_queue_init_tags(struct request_queue *q, { struct blk_queue_tag *tags; - tags = kmalloc(sizeof(struct blk_queue_tag), GFP_ATOMIC); + tags = kmalloc(sizeof(struct blk_queue_tag), GFP_KERNEL); if (!tags) goto fail; -- 1.7.9.5