Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 25 Jan 2018 10:59:39 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     mikelley@microsoft.com
Cc:     linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
        olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com,
        jasowang@redhat.com, leann.ogasawara@canonical.com,
        marcelo.cerri@canonical.com, sthemmin@microsoft.com,
        kys@microsoft.com, x86@kernel.org, jrp@pun.org
Subject: Re: [PATCH v2 char-misc 1/1] Drivers: hv: vmbus: Implement Direct
 Mode for stimer0
Message-ID: <20180125095939.GA16968@kroah.com>
References: <20180122222929.3762-1-mikelley@exchange.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180122222929.3762-1-mikelley@exchange.microsoft.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 22, 2018 at 03:29:29PM -0700, mikelley@exchange.microsoft.com wrote:
> +/*
> + * If false, we're using the old mechanism for stimer0 interrupts
> + * where it sends a VMbus message when it expires. The old
> + * mechanism is used if Direct Mode is explicitly disabled
> + * by the module parameter, or on older versions of Hyper-V
> + * that don't support Direct Mode. While Hyper-V provides
> + * four stimer's per CPU, Linux uses only stimer0.
> + */
> +static bool direct_mode_enabled = true;
> +module_param(direct_mode_enabled, bool, 0444);
> +MODULE_PARM_DESC(direct_mode_enabled,
> +			"Set to N to disable stimer Direct Mode.");

Ick ick ick.  How is a distro or user supposed to know if/when to enable
this and not to enable it?  This isn't ok, can you please make this
"automatic" to always do the right thing based on what it is running on?

Module parameters are not a good idea as they are impossible to maintain
and document and use over time.  Please never add new ones to the
kernel.

thanks,

greg k-h