Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 25 Jan 2018 11:38:08 +0000
From:   Daniel Thompson <daniel.thompson@linaro.org>
To:     Baolin Wang <baolin.wang@linaro.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Jason Wessel <jason.wessel@windriver.com>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        kgdb-bugreport@lists.sourceforge.net,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kdb: Change timespec to use timespec64
Message-ID: <20180125113808.3bzgh6zloosw76yv@oak.lan>
References: <acb789d2e1df1c30d6dfcb9452fef1a398c3b113.1516867148.git.baolin.wang@linaro.org>
 <CAK8P3a2BtM-oW4ZVRg6S6aS30b4FD9MHvQWP4hKuGC1XXbbG1g@mail.gmail.com>
 <CAMz4kuKu9pONLRbh6wKT88QV_vyBW1AQ=ss-qx0s6_i+-AxX9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMz4kuKu9pONLRbh6wKT88QV_vyBW1AQ=ss-qx0s6_i+-AxX9g@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 25, 2018 at 05:18:54PM +0800, Baolin Wang wrote:
> On 25 January 2018 at 16:55, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Thu, Jan 25, 2018 at 9:05 AM, Baolin Wang <baolin.wang@linaro.org> wrote:
> >> @@ -2554,7 +2554,7 @@ static int kdb_summary(int argc, const char **argv)
> >>         kdb_printf("domainname %s\n", init_uts_ns.name.domainname);
> >>         kdb_printf("ccversion  %s\n", __stringify(CCVERSION));
> >>
> >> -       now = __current_kernel_time();
> >> +       now = current_kernel_time64();
> >>         kdb_gmtime(&now, &tm);
> >>         kdb_printf("date       %04d-%02d-%02d %02d:%02d:%02d "
> >>                    "tz_minuteswest %d\n",
> >
> > Thanks for picking this one up again, we should find a permanent solution here.
> > Unfortunately you patch is incorrect, as we cannot safely call
> > current_kernel_time64()
> > from NMI context.
> 
> Ah, thanks for pointing out the issue, since I do not know what
> context the function will be called in kdb.
> 
> >
> > The __ prefix on __current_kernel_time() indicates that this is a special call
> > that intentionally doesn't read the hardware time to avoid taking locks that
> > might already be held in the context from which we entered the debugger.
> >
> > See https://patchwork.kernel.org/patch/10002097/ for my earlier patch.
> 
> This patch had not been merged into mainline?

Not yet (and I'm afraid it's not in kgdb-next either) but the ack from Jason is from 
this kernel cycle so we'll see what can be done!


Daniel.