Received: by 10.223.176.46 with SMTP id f43csp2065481wra; Thu, 25 Jan 2018 04:26:47 -0800 (PST) X-Google-Smtp-Source: AH8x225yYzbRwmJ941BSjcW32Sk02Smvk8PUm8gXUDgsOSFydYPO5y8GNLEzgMpW5Lw9fDynU8I9 X-Received: by 2002:a17:902:d683:: with SMTP id v3-v6mr11199709ply.52.1516883207558; Thu, 25 Jan 2018 04:26:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516883207; cv=none; d=google.com; s=arc-20160816; b=bBNrCwnMat0X8zH7Z73XVgC00xELL5tf/utnNqSw323LuJr6wAsDEpebyB3KCdg+vQ zqlXeHKzraFs3x8fJUTWYuF00h01VJszzZbtOu7lYH6zCPxWXhhDoHhA8+X91MVnS95/ ylDtfsrVKSf4+0aY4LMLsKUe8j43HheL2FHnQ16pZ1xQerVTIfCZ/aQO+0KWjZ6aFtmK gfgDqd260FGPcHgPem9PsngQFMOeRhoUBGR/LBSdnG9/T7BdmszNp98i2175t+mBdA6Q rKBJjorm6n40833y6WZ7bqBpX2CyFpFcLoIR02tese9qau9EWnfXI0yzSvzKo0WblYyd qgUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=fuHWdJc12mM8FjAMXsT/uJ/viPK2jxKsKeNQ6tMzp9I=; b=ZdMELeVap9mlwaYKuSFtK9yJonLiAJjKFMzkT4lVZXHNoFdJaHM7y6ZjRCrAvRAfIk TSbe4POwWgTSrIqCM0+lbPojj4k0mD1hGfgFflSNx6BXciyRoSz5ljx/7dS3vqFFCcZj j602i3f09Q3V4N4TsbPLqrd7/Noyi9YBbvH7iF55UAi7YaNvPtCvk2MvmDQngVvoYuEG N+RKXPJwMHETEcUq22doMMvdUzoH6y1nA44s4MJN+EMwlpdvCoIQz/4Jlb8Vcx5D5bQ9 Cc/RgvmVE+xZyeOa7EwG8bGlU7v66BXQGNK1C2cuoYtRXQPvDZleWitqgxDcBY3Ki+IF ao4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a61-v6si1871894plc.593.2018.01.25.04.26.33; Thu, 25 Jan 2018 04:26:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbeAYLuZ (ORCPT + 99 others); Thu, 25 Jan 2018 06:50:25 -0500 Received: from mail.skyhub.de ([5.9.137.197]:37730 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbeAYLuY (ORCPT ); Thu, 25 Jan 2018 06:50:24 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mYPPzZR7Op1u; Thu, 25 Jan 2018 12:50:23 +0100 (CET) Received: from pd.tnic (p200300EC2BD0EE0024194793E6CFFC7A.dip0.t-ipconnect.de [IPv6:2003:ec:2bd0:ee00:2419:4793:e6cf:fc7a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 68CC91EC045C; Thu, 25 Jan 2018 12:50:23 +0100 (CET) Date: Thu, 25 Jan 2018 12:50:16 +0100 From: Borislav Petkov To: David Woodhouse Cc: arjan@linux.intel.com, tglx@linutronix.de, karahmed@amazon.de, x86@kernel.org, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com, peterz@infradead.org, pbonzini@redhat.com, ak@linux.intel.com, torvalds@linux-foundation.org, gregkh@linux-foundation.org, dave.hansen@intel.com, gnomes@lxorguk.ukuu.org.uk, ashok.raj@intel.com, mingo@kernel.org Subject: Re: [PATCH v4 7/7] x86/speculation: Add basic IBPB (Indirect Branch Prediction Barrier) support Message-ID: <20180125115016.ov72ajqb6z7scdrc@pd.tnic> References: <1516872189-16577-1-git-send-email-dwmw@amazon.co.uk> <1516872189-16577-8-git-send-email-dwmw@amazon.co.uk> <20180125114127.5iw4vy56bb2cs5mr@pd.tnic> <1516880855.30244.78.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1516880855.30244.78.camel@infradead.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 25, 2018 at 11:47:35AM +0000, David Woodhouse wrote: > I did already do the explicit clobbers now you reminded me how to do > them, but I elected not to use ASM_NO_INPUT_CLOBBER() because on > balance, losing the MSR_IA32_PRED_CMD / PRED_CMD_IBPB definitions and > having to hard-code the numbers was not so much of a win. and I'm thinking exactly the opposite: if an alternative can lose a bunch of inputs which don't change, then that's a good thing. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.