Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1516882990.7000.1250.camel@linux.intel.com>
Subject: Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI
 driver to boot a host with PCH runs on eSPI
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     "Wang, Haiyue" <haiyue.wang@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     joel@jms.id.au, arnd@arndb.de, openbmc@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 25 Jan 2018 14:23:10 +0200
In-Reply-To: <b1584518-2938-7faa-cd83-d0245d1ba88f@linux.intel.com>
References: <1516103552-19601-1-git-send-email-haiyue.wang@linux.intel.com>
         <20180123084457.GE21463@kroah.com>
         <b1584518-2938-7faa-cd83-d0245d1ba88f@linux.intel.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2018-01-25 at 10:29 +0800, Wang, Haiyue wrote:
> 
> On 2018-01-23 16:44, Greg KH wrote:
> > On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote:

> > > +	depends on ARCH_ASPEED || COMPILE_TEST
> > > +	select REGMAP_MMIO
> > 
> > Select or depend?
> 
> Before, I used "depends on". I was told to to change "select". I'm
> not 
> sure which is more better by practice ?

git grep will answer to this question, but also documentation is good to
read.

REGMAP API is selected by users.

One case where it's not so looks like a bug.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy