Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 25 Jan 2018 15:14:51 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Meghana Madhyastha <meghana.madhyastha@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Noralf =?utf-8?Q?Tr=C3=B8nnes?= <noralf@tronnes.org>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper
 in backlight.c
Message-ID: <20180125141451.GD27888@ulmo>
References: <cover.1516810725.git.meghana.madhyastha@gmail.com>
 <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="q9KOos5vDmpwPx9o"
Content-Disposition: inline
In-Reply-To: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--q9KOos5vDmpwPx9o
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 24, 2018 at 04:35:30PM +0000, Meghana Madhyastha wrote:
> Add of_find_backlight, a helper function which is a generic version
> of tinydrm_of_find_backlight that can be used by other drivers to avoid
> repetition of code and simplify things.
>=20
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> Reviewed-by: Noralf Tr=C3=B8nnes <noralf@tronnes.org>
> Reviewed-by: Sean Paul<seanpaul@chromium.org>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> ---
>  drivers/video/backlight/backlight.c | 43 +++++++++++++++++++++++++++++++=
++++++
>  include/linux/backlight.h           | 19 ++++++++++++++++
>  2 files changed, 62 insertions(+)
>=20
> diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backligh=
t/backlight.c
> index 8049e7656..553bf5c48 100644
> --- a/drivers/video/backlight/backlight.c
> +++ b/drivers/video/backlight/backlight.c
> @@ -580,6 +580,49 @@ struct backlight_device *of_find_backlight_by_node(s=
truct device_node *node)
>  EXPORT_SYMBOL(of_find_backlight_by_node);
>  #endif
> =20
> +/**
> + * of_find_backlight - Get backlight device
> + * @dev: Device
> + *
> + * This function looks for a property named 'backlight' on the DT node
> + * connected to @dev and looks up the backlight device.
> + *
> + * Call backlight_put() to drop the reference on the backlight device.
> + *
> + * Returns:
> + * A pointer to the backlight device if found.
> + * Error pointer -EPROBE_DEFER if the DT property is set, but no backlig=
ht
> + * device is found.
> + * NULL if there's no backlight property.
> + */
> +struct backlight_device *of_find_backlight(struct device *dev)

Just a nit: there isn't really anything OF specific about this. It would
be if this took a struct device_node * as parameter. So technically you
could implement this for ACPI or whatever other firmware interface as
well. So I think a more idiomatic name for this would be:

	struct backlight_device *backlight_get(struct device *dev);

which would match the:

	void backlight_put(struct backlight_device *bd);

and be consistent with how other resources are obtained. Not a big deal,
though. It can always be changed later on.

Reviewed-by: Thierry Reding <treding@nvidia.com>

--q9KOos5vDmpwPx9o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlpp5lsACgkQ3SOs138+
s6Gmeg/+I2qe8/dpeKRIt+7QEqkQUwtgCeFDcW1yRK0viQhnxzluLLjj4HQY6BWn
4V4QupGOItwPJGUfToMO3lO90MHQ8d9QZZgQlvPWsyfeQZiXltm5y7GELCi4yW/I
ZxqHmjkY3uvIbap7gLf2Jq3uq9obm08SQ28o0bw9xD+jZ2HhnGgiBgh73pbNRWnS
KN+L7SlYQiAgxO6uQgV3MgdoF3SLELujFdRs5QbT51bnauQYPN5kGB9NiPemTWz2
3CgXtVsEqhtrxRCb0sfBD6PxMqmBdcal7ja3kXCoKRW0c67kAfD8VkRn9nv3420G
ChPbEnBKExaw5Ks4ugh2t268sNhAPW0jX4UY+RF9ipZ2GF5om87bl8p0HmPt2o1P
10r9+BCwEOBagUjOyE6QKdUPpJzw+nT3dBQ1uSvoUID559LDk/+TPqUOowBOzfxi
p5KELpaxU1WYJW2CZhySC2rWH35VN/hLgw+tPjQv13woj8/uh8z5TmpqDGi6/GEm
8PA3wpqnssz/3u2x8Y7yv9uhjtFh/U8ScFE8afgR1xV2OUCMHUpSdXKK7EreJJLt
Oxzg2woqJd3kU8KzIHCA5twJysxujyAoN+GfNxXLB2emUz+0/mDCZVpHCC7tEp9h
Qr8WyO3DPEDZ/qwOyY7KpKaKrPTVOjD2sILFZhKZzhLusxDnItE=
=0z1I
-----END PGP SIGNATURE-----

--q9KOos5vDmpwPx9o--