Received: by 10.223.176.46 with SMTP id f43csp2287462wra; Thu, 25 Jan 2018 07:40:29 -0800 (PST) X-Google-Smtp-Source: AH8x224ud2ZfSnsgvKTd7mu662rfLXhvOYvISyuox4fxkEzMjrtzX1rBmmMpW4CFqtU1HjqAMUFj X-Received: by 2002:a17:902:b109:: with SMTP id q9-v6mr4394122plr.396.1516894829375; Thu, 25 Jan 2018 07:40:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516894829; cv=none; d=google.com; s=arc-20160816; b=CzMe+SgZZ9dhuAnzgK3jJ73KpMOEjvGqSOZBJ+k6K8QKS+bTCQTCHZ5pIgjkTW6gio q0F++aW2hOWQYqbObbyAQ5LDY1wdSDDkAeMf5UFBHwzSji7WwKk+tNBLkJfHniNVh7gb ZvISSqf3lMqiTfyitzG5Q8I2KKJuzUyCHs8QpoYMnnnJj8NFeV0BOEnwsSBG7f2XNbTG k+sSUx2HIzrD8bdMUgO1ndlg48m5b3S9t43JEQ6BrJmApsyt/nCZjd3fF2/cEU+V8WE6 cUfe5GwWU48ZA1W0lifDG/ytcLojsHPhvCmLtS+xf2bcMti1r1+iCz5vWUj8lOf0WvJn U+nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:arc-authentication-results; bh=g4Xqzt7F7oqjfUUhIfcGiQmlrvWG/b/28U5av/rhJaw=; b=qgoJYgJmaou7A/f64J0b/yNQaciq0qh0fyss1yr9PW7S8zaT4LFKIJR3UzD+COkeVF oUW1Yk0dSVZvZvqtMyFROSS1Wgh9s5ezsVFAQtHsp28VosfYZbOWMDFpLyciTkHuKiht Gf0wGZh8krsMhQH904GW7Vx4T3bzbClrNBZE5InQNLWjqDQl8QrFd54OiHQDL2b2j8c3 Ell2TorEAnQUsI9Rez7NtP1KVJU4wv+6+slhJ0Jz+ofsm99MjyucD11/GrR7W0Nma3xc EgrVGHF/q5szsPFspDi32oNcE3fXH+R0JbMi+b6ilw0DPIPh+dbo52hogKRBEr7HpRaN wt9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2si1697941pgf.90.2018.01.25.07.40.14; Thu, 25 Jan 2018 07:40:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751420AbeAYPj2 (ORCPT + 99 others); Thu, 25 Jan 2018 10:39:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:42182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbeAYPj0 (ORCPT ); Thu, 25 Jan 2018 10:39:26 -0500 Received: from localhost.localdomain (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38DED21781; Thu, 25 Jan 2018 15:39:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38DED21781 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=atull@kernel.org From: Alan Tull To: Moritz Fischer Cc: Alan Tull , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH] fpga: fpga-region: comment on fpga_region_program_fpga locking Date: Thu, 25 Jan 2018 09:39:22 -0600 Message-Id: <20180125153922.3119-1-atull@kernel.org> X-Mailer: git-send-email 2.14.2 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a comment to the header of fpga_region_program_fpga() regarding locking of the bridges. Signed-off-by: Alan Tull --- drivers/fpga/fpga-region.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index edab2a2..cb0603e 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -95,6 +95,11 @@ static void fpga_region_put(struct fpga_region *region) * fpga_region_program_fpga - program FPGA * @region: FPGA region * Program an FPGA using fpga image info (region->info). + * If the region has a get_bridges function, the exclusive reference for the + * bridges will be held if programming succeeds. This is intended to prevent + * reprogramming the region until the caller considers it safe to do so. + * The caller will need to call fpga_bridges_put() before attempting to + * reprogram the region. * Return 0 for success or negative error code. */ int fpga_region_program_fpga(struct fpga_region *region) -- 2.7.4