Received: by 10.223.176.46 with SMTP id f43csp2394582wra; Thu, 25 Jan 2018 09:10:58 -0800 (PST) X-Google-Smtp-Source: AH8x225Hfuexf5weS/cMXhlwq03FAul5YfaXIzwbgyq/FiqN7qYVWf1s6dM+LsEGduuaDIFcnPoS X-Received: by 10.99.113.67 with SMTP id b3mr9563936pgn.134.1516900258336; Thu, 25 Jan 2018 09:10:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516900258; cv=none; d=google.com; s=arc-20160816; b=Jo4Ry+g6WfvI6C6bChsgefpacpQz68ThNZoKCweRN0Drs+SuLDP/blEUTmzzjgy1YS 2PyVEQy8q8Mdzb9d1U1BDEXaX0ajCRVv0EwP6+PWhymdgBm4DvG92q6EU56hcYClO87N nDUTB250WFtGVrntV98c3rLFblSK179s5TRC1sMbhmAm/KHJuO7hBNgZTcr0HXugoTUv df9DabOhCxNkerLWxTbQPapmidpcOTMS299QRv7xPdVBr/SXpUnCdDeOxQ1SFVQo8KoT YSuFXOA+wXvgJGI9Yf6eeFhnzACH/lzlvXouMV+UzuVoNvM/y9GSRn9zhy+bJpRF97sq WB6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=zKqHpIKB2dSlrsqhJL9y5tfl8C7fMrVmcvhNqncz+y8=; b=Dd+pQh+VT+EbCPKZHSn2tKfv4oe2A/i7zZDkt+3Mv/11maQtB+RJ4Knb4l8wnPZ7vH LULoGXc2IX5V0ZMl3mKdWG6vuMKzV9Z6Ei2elyGqltwcHtppCsijwm6PaUVY/XIpj5nP fElJhmlzchrJ7LShcx0PMDTl3m4oONu/vMAJAgxOFVtLJ3rrernToWzqKtidx+ZyR11a h7bM4KElDQ3ctPJoBq9Q/Pj6MnPsyNk1QA3ZyVO0d3kTdjQJhmwgdiTzwD+dgm7ipwKx 7Bm5ll7pC7QnVOPosqXQN7LVreI4WspPrwg//0a4qL9SX3SFiKkaKCjjPCMeN7tXb61C Ojaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=Zd/MPNg3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si2256250plz.69.2018.01.25.09.10.43; Thu, 25 Jan 2018 09:10:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=Zd/MPNg3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267AbeAYRJt (ORCPT + 99 others); Thu, 25 Jan 2018 12:09:49 -0500 Received: from mail-db5eur01on0083.outbound.protection.outlook.com ([104.47.2.83]:24992 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750992AbeAYRJq (ORCPT ); Thu, 25 Jan 2018 12:09:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zKqHpIKB2dSlrsqhJL9y5tfl8C7fMrVmcvhNqncz+y8=; b=Zd/MPNg3wRSQ5rVghqUioFEvUzbsEhILMqoPp9oJPuKG63CESPCCjNfNus9MMvJQb8xZpWYpdMiKpXP0JB6e4gcgWSVgJ13SNaH79J/PguU4SJwVyra1esYxuQMnAniYZTGRTwYDiRKBJJJjkIvqYXgLp5atTydc1I4ArQT6KwQ= Received: from VI1PR0402MB3342.eurprd04.prod.outlook.com (52.134.8.142) by HE1PR04MB3227.eurprd04.prod.outlook.com (10.170.253.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 25 Jan 2018 17:09:43 +0000 Received: from VI1PR0402MB3342.eurprd04.prod.outlook.com ([fe80::3507:8836:aae3:375e]) by VI1PR0402MB3342.eurprd04.prod.outlook.com ([fe80::3507:8836:aae3:375e%13]) with mapi id 15.20.0428.024; Thu, 25 Jan 2018 17:09:42 +0000 From: =?iso-8859-2?Q?Horia_Geant=E3?= To: Bryan O'Donoghue , Aymen Sghaier , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Fabio Estevam , Peng Fan , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "lukas.auer@aisec.fraunhofer.de" , "rui.silva@linaro.org" , "ryan.harkin@linaro.org" Subject: Re: [RESEND PATCH 1/6] crypto: caam: Fix null dereference at error path Thread-Topic: [RESEND PATCH 1/6] crypto: caam: Fix null dereference at error path Thread-Index: AQHTlSK2HNOQ3C9v/kaxyx22YtW9nA== Date: Thu, 25 Jan 2018 17:09:42 +0000 Message-ID: References: <1516805435-15034-1-git-send-email-pure.logic@nexus-software.ie> <1516805435-15034-2-git-send-email-pure.logic@nexus-software.ie> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [86.34.165.90] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR04MB3227;7:3pqt2rVfftzpHZIFHkljk9fHEY6qYM3lFm34WqGDIk7FMaq1V6cQnqw8DzU+etCvaPDKgmH47vD01JbYq9x4p84sdli6WJZKITXxAHxBvkfBBi48YWzLoLUGtazQH1rB94pcKB91RFBzTFf3O7ojGLkBoDR2xaif67sUps6Vl3avGi0VLmShfafcDfa8hyZOt6r9PRkH4WgZW9Ywhj6d6oH7sOqva+kK+aq3m2spt4IgmexSZVXXWYlySFf3fo4n x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(366004)(376002)(39860400002)(396003)(346002)(39380400002)(199004)(189003)(110136005)(3846002)(6436002)(3280700002)(3660700001)(6116002)(81166006)(76176011)(7696005)(99286004)(478600001)(8936002)(2501003)(5250100002)(81156014)(74316002)(9686003)(2906002)(186003)(26005)(8676002)(102836004)(6506007)(7736002)(229853002)(305945005)(55016002)(53546011)(86362001)(2201001)(106356001)(66066001)(105586002)(2900100001)(33656002)(25786009)(6246003)(316002)(54906003)(5660300001)(4326008)(14454004)(97736004)(53936002)(68736007)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR04MB3227;H:VI1PR0402MB3342.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 011f57f4-4d5c-4ab3-cc65-08d564166d1e x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:HE1PR04MB3227; x-ms-traffictypediagnostic: HE1PR04MB3227: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:HE1PR04MB3227;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB3227; x-forefront-prvs: 0563F2E8B7 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Gn4M889ISvOy8cXCMLipKOw3y+xNoicy7IlnsaYHsu4UCXRnQZlxafBjWjQnpL5m1F0B4detU/Be/xTBT2VMGQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 011f57f4-4d5c-4ab3-cc65-08d564166d1e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 17:09:42.4492 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3227 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/2018 4:50 PM, Bryan O'Donoghue wrote:=0A= > From: Rui Miguel Silva =0A= > =0A= > caam_remove already removes the debugfs entry, so we need to remove the o= ne=0A= > immediately before calling caam_remove.=0A= > =0A= > This fix a NULL dereference at error paths is caam_probe fail.=0A= > =0A= > [bod: changed name prefix to "crypto: caam: Fix .."]=0A= > [bod: added Fixes tag]=0A= > =0A= > Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend=0A= > support")=0A= Cc: # 4.12+=0A= =0A= > =0A= > Tested-by: Ryan Harkin =0A= > Signed-off-by: Rui Miguel Silva =0A= > Cc: "Horia Geant=E3" =0A= > Cc: Aymen Sghaier =0A= > Cc: Fabio Estevam =0A= > Cc: Peng Fan =0A= > Cc: Herbert Xu =0A= > Cc: "David S. Miller" =0A= > Cc: Lukas Auer =0A= > Signed-off-by: Bryan O'Donoghue =0A= Reviewed-by: Horia Geant=E3 =0A= =0A= Thanks,=0A= Horia=0A=