Received: by 10.223.176.46 with SMTP id f43csp2462611wra; Thu, 25 Jan 2018 10:11:34 -0800 (PST) X-Google-Smtp-Source: AH8x225/JKnjeBQXeYX4JJc4l/3pq6xkm6EdLjK946k4rb9uK/2AGiJudI5/nx9l0fLYh2bpvvWb X-Received: by 2002:a17:902:4222:: with SMTP id g31-v6mr11910839pld.203.1516903894246; Thu, 25 Jan 2018 10:11:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516903894; cv=none; d=google.com; s=arc-20160816; b=qDhNEscZKgp2dzEtBEtF3F9WQj7krkHsdEjNXA/CJ7BzTPWm55RDE4GZ+yV9dkcSpf nSRu4NG40X8iwMXS6BaS/E83Z89qbBMo1Kg02l9xA7UB3hF48tLxevsOk9HFQFHGFCQc 8RNdjAyAR3/YZTfAMN1oXAlpXGWWb9FFlR+HET+aM+qammu7oz9U06LyZ2rSWK5Ccu/K 6koQHqDxbzLSsOlKTazOvBQddgz16gLW6de4vu+/Y91dzNsMnwJIcfvUTt1zw+EduQjf 0xhUnOGsfVzRX/bu2VWQ+KXwdqnIzhz3TT2YliwzrdaXfwIhfIn8HwtDSr912I5i/h/B dYQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:arc-authentication-results; bh=0/peYR+rGdUSbIYFUi+eapBLYIfgpWokNSfXHHzV3cE=; b=UucPpV86b3n96flA//zRimGJYAi/VwYy8P5cBOgWVcpYQMpL8uWpd7ioTw39szaKuq QwCXR+KrkuKtruyVP6EKNmzS0+rhJX3OMmPw9+l5gRMP5m/xaas5mKzU38Il8TkNLuZz 7GCzbUw33p3RlaESE1JiU60NNMH75tplyw/t22OfglGeMUyh44CJN9fZcp15nhZYJSOA a1O2Urt50QjZ46hD7mAIXRw8WwSM/4wlgituEJNlmq8DfMoF/5z6rvAq15b8UJKf3fDn uyb1EbaIMjyTlUEVp15Es+j1dgMG9iCU42FlTD6H5yt5+gFClvPEKOolZVy9i0nWV+Ch q92w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h64si290208pgc.416.2018.01.25.10.11.19; Thu, 25 Jan 2018 10:11:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751255AbeAYSKz (ORCPT + 99 others); Thu, 25 Jan 2018 13:10:55 -0500 Received: from mga02.intel.com ([134.134.136.20]:24397 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbeAYSKy (ORCPT ); Thu, 25 Jan 2018 13:10:54 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2018 10:10:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,412,1511856000"; d="scan'208";a="26342185" Received: from ray.jf.intel.com (HELO [10.7.201.17]) ([10.7.201.17]) by orsmga001.jf.intel.com with ESMTP; 25 Jan 2018 10:10:53 -0800 Subject: Re: [PATCH v5 5/7] x86/pti: Do not enable PTI on processors which are not vulnerable to Meltdown To: David Woodhouse , arjan@linux.intel.com, tglx@linutronix.de, karahmed@amazon.de, x86@kernel.org, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com, bp@alien8.de, peterz@infradead.org, pbonzini@redhat.com, ak@linux.intel.com, torvalds@linux-foundation.org, gregkh@linux-foundation.org, gnomes@lxorguk.ukuu.org.uk, ashok.raj@intel.com, mingo@kernel.org References: <1516896855-7642-1-git-send-email-dwmw@amazon.co.uk> <1516896855-7642-6-git-send-email-dwmw@amazon.co.uk> From: Dave Hansen Message-ID: Date: Thu, 25 Jan 2018 10:10:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1516896855-7642-6-git-send-email-dwmw@amazon.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/2018 08:14 AM, David Woodhouse wrote: > +static bool __init early_cpu_vulnerable_meltdown(struct cpuinfo_x86 *c) > +{ > + u64 ia32_cap = 0; > + > + if (x86_match_cpu(cpu_no_meltdown)) > + return false; > + > + if (cpu_has(c, X86_FEATURE_ARCH_CAPABILITIES)) > + rdmsrl(MSR_IA32_ARCH_CAPABILITIES, ia32_cap); > + > + /* Rogue Data Cache Load? No! */ > + if (ia32_cap & ARCH_CAP_RDCL_NO) > + return false; > + > + return true; > +} Feel free to add my ack on this. It looks fine to me. I'll test and submit any necessary fixes once I actually get a system that has this bit.