Received: by 10.223.176.46 with SMTP id f43csp2691754wra; Thu, 25 Jan 2018 13:42:33 -0800 (PST) X-Google-Smtp-Source: AH8x224clf1kAreH2Ehe1ZQ1DqbBExURj676ZfW272KLeX0VMaRneKmbd2COi1Ucf/7Aw037XV1B X-Received: by 10.98.223.196 with SMTP id d65mr17505618pfl.176.1516916553866; Thu, 25 Jan 2018 13:42:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516916553; cv=none; d=google.com; s=arc-20160816; b=R6qgkMdoFkplZHYsvRsPU6EM9Q9Byuqqy5UkUYvcLt1w4o9j+4t6FnDiBpPKMtYxBA vx77TyHNUJuiaefB7V4EDpM6qAtzJoYo5qxp7L+rE8F0RBqFNJDE/ewfZc1xNyEOgHgK Nf4CvLyNI87om9vADEw/BBMavpB9wHMmAcmu3eB4mAYWRNsWF2xY4wgmzJGqIbithHDz Yu+goI7sumGnocslvGlzlINizhpaf9eoiDGWmFb6hU0XFOtCRNrRFl9dhe2NQJFCeQN/ UnDJqYr8ZInubsrEJjNMSpHjP2SqjLjtpZBs4db+QvXAWYLgBYqq20FQZP/p2tcMNo9v PuQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=pOmkMLoNycaXCCMjdbze6NJt/ml5IStN3afy2+oOIbg=; b=IXtIpgO3WASmX2S+p3nhSYTO4u/3I8PMCSsZZh3PZ5jV9BRqNWXiy67pRMZooe7LWl gw7eEZaMQdMfOXez3mrge2FXBuz+D7Ylk8qwgS6I0XD2AVDPlJ2p2Yg2q3ePB09yckYo bZqLPSwQMyoJU5o7044WuVDF0oLhcOyZKvYfp6lgt9FVH5F0JYZ4ysO+gOw1Zb1gbmq/ w0XIrIs4kpPNRRVGhvsrCZD4czBomtcQ8xf3OHj1piYFLnjLrNPX57dSLrm4NL1sCn/N Pk/CePLL25DWeEFYEcTeUXeM/iXl+XOUqugxr0MIifs6YBWGheU5AO/7SWGzjdBQDU4u CrcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12si2056134pgc.64.2018.01.25.13.42.19; Thu, 25 Jan 2018 13:42:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751450AbeAYVls (ORCPT + 99 others); Thu, 25 Jan 2018 16:41:48 -0500 Received: from mga14.intel.com ([192.55.52.115]:57052 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbeAYVlr (ORCPT ); Thu, 25 Jan 2018 16:41:47 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2018 13:41:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,413,1511856000"; d="scan'208";a="22363005" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by orsmga003.jf.intel.com with ESMTP; 25 Jan 2018 13:41:46 -0800 Date: Thu, 25 Jan 2018 14:45:19 -0700 From: Keith Busch To: Jianchao Wang Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, maxg@mellanox.com, james.smart@broadcom.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESENT] nvme-pci: introduce RECONNECTING state to mark initializing procedure Message-ID: <20180125214519.GB20258@localhost.localdomain> References: <1516629796-2919-1-git-send-email-jianchao.w.wang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516629796-2919-1-git-send-email-jianchao.w.wang@oracle.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 22, 2018 at 10:03:16PM +0800, Jianchao Wang wrote: > After Sagi's commit (nvme-rdma: fix concurrent reset and reconnect), > both nvme-fc/rdma have following pattern: > RESETTING - quiesce blk-mq queues, teardown and delete queues/ > connections, clear out outstanding IO requests... > RECONNECTING - establish new queues/connections and some other > initializing things. > Introduce RECONNECTING to nvme-pci transport to do the same mark. > Then we get a coherent state definition among nvme pci/rdma/fc > transports. > > Suggested-by: James Smart > Reviewed-by: James Smart > Signed-off-by: Jianchao Wang This looks fine. Thank you for your patience. Reviewed-by: Keith Busch