Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH 1/2] x86/ibpb: Skip IBPB when we switch back to same
 user process
To:     Andy Lutomirski <luto@kernel.org>, Andi Kleen <ak@linux.intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        KarimAllah Ahmed <karahmed@amazon.de>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Asit Mallick <asit.k.mallick@intel.com>,
        Borislav Petkov <bp@suse.de>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "H . Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
        Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jun Nakajima <jun.nakajima@intel.com>
References: <c5cc429013c2248ddebe0a8480b172ae70b29733.1516840211.git.tim.c.chen@linux.intel.com>
 <20180125085820.GV2228@hirez.programming.kicks-ass.net>
 <20180125092233.GE2295@hirez.programming.kicks-ass.net>
 <86541aca-8de7-163d-b620-083dddf29184@linux.intel.com>
 <20180125135055.GK2249@hirez.programming.kicks-ass.net>
 <aeef4a08-7dd3-3d3a-02f4-9b8b4a1461bf@linux.intel.com>
 <20180125164139.GM2269@hirez.programming.kicks-ass.net>
 <CALCETrVeb7g+wAP8hox9TEBBWYAFXGzOv5t2aQVrtuW4D6NQQQ@mail.gmail.com>
 <20180125181852.GL2249@hirez.programming.kicks-ass.net>
 <aa7cfe53-d8ee-9f56-a5c7-775d878cee15@linux.intel.com>
 <20180125204625.GN2269@hirez.programming.kicks-ass.net>
 <CALCETrUGDeHse24sOygh5EcsXuZHPtZnw3adhzADfn+yKgcOzg@mail.gmail.com>
 <87h8r9k3du.fsf@linux.intel.com>
 <CALCETrVnMT+hTL+U2s6Axhr3KmJY+L+czpkbmQd3qytB6FHnGw@mail.gmail.com>
From:   Tim Chen <tim.c.chen@linux.intel.com>
Message-ID: <f232ce18-3122-b045-be92-76fd61b195b5@linux.intel.com>
Date:   Thu, 25 Jan 2018 15:07:11 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <CALCETrVnMT+hTL+U2s6Axhr3KmJY+L+czpkbmQd3qytB6FHnGw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/25/2018 02:01 PM, Andy Lutomirski wrote:
> On Thu, Jan 25, 2018 at 1:57 PM, Andi Kleen <ak@linux.intel.com> wrote:
>> Andy Lutomirski <luto@kernel.org> writes:
>>>
>>> That being said, just stashing last_user_mm without any refcounting
>>> should be fine.
>>
>> If last_user_mm is freed and reallocated by a different process,
>> then that would miss the IPBP incorrectly.
>>
> 
> Hmm, right.  So ctx_id it is.
> 
> --Andy
> 
Thanks.  Using ctx_id is a pretty clean approach.  I will refresh
this patch and drop the second patch.

Tim