Received: by 10.223.176.46 with SMTP id f43csp2821345wra; Thu, 25 Jan 2018 16:01:26 -0800 (PST) X-Google-Smtp-Source: AH8x227AsZrJHtewsujBaP6Y3kbXLvWGBiVlzCXdOl7NeLMZwxYfizfbBVko1WKwB0tA6eMLJECD X-Received: by 10.99.60.88 with SMTP id i24mr14286532pgn.1.1516924886210; Thu, 25 Jan 2018 16:01:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516924886; cv=none; d=google.com; s=arc-20160816; b=nnbSuBtoaXzfWoM+N0EpcnbQFpAGqPvKLOhLledA+KrJYPvKqLtYBNgQPe+3Y/TWqW gaFBQUa7sECYDiu0h4Y2FEamKoAzh5VKhizhdymWY+1cIECJ3797hBmnrtPXFFvd8sQv URhDQgBg0WY4B1O4HkqbH7Bv36BYtQQfBhxE7p0D+fBjD7zTJ8US46l0RJ9KNQnnthhe fioOgKyRYY3hw3SrdHyldazLysJN61yvekxav9OU2YohJErXRPXUbZ4iqcbuOkCWaELh SL0rQbV6+gBghweELVlBI+tYvC52VDWRKi47YOY755boLyicFX5ngDCfehsm251H0a4b bAKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=zZ/kqVTJMaisSdJa/oYwWTE5vm+WM+rBa5j6XKTM4zg=; b=utuFkHBI4+BWjn8jBBbVOZMbwoBV07FZe9uRlfsaxTzpknSvJYHpVhaMHmqyVsuZ+k mzzrNKhM622xbHpMhg/3OTJMN5rZ8Yr0hJGs/mv4Gj9TsJdsvxKiIEzxk3Pz0FqPKi+p VyWDG+1EFbYmS1zRrv1YQBy8SMv/qhJE333IH0P06xBi+RevxY0Dv25xUherCJcRJL8z pklBa2dFHOrEmpwJi0u7q1vUB1OFf0JvJuwtmir1X00aQuNx3PK3VOf7KA6wyfb0up8m gcABiw8bEiBoDgsNl/W+vKQeOM2SeF1Nq0E0FZdWnSvug02antlx/OOCtuFRvABNx8zm pCSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f61-v6si2747989plb.179.2018.01.25.16.01.10; Thu, 25 Jan 2018 16:01:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751950AbeAZAAZ (ORCPT + 99 others); Thu, 25 Jan 2018 19:00:25 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37422 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbeAZAAS (ORCPT ); Thu, 25 Jan 2018 19:00:18 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 48157BC5; Fri, 26 Jan 2018 00:00:17 +0000 (UTC) Date: Thu, 25 Jan 2018 16:00:16 -0800 From: Andrew Morton To: David Rientjes Cc: Roman Gushchin , Michal Hocko , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable Message-Id: <20180125160016.30e019e546125bb13b5b6b4f@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jan 2018 15:53:48 -0800 (PST) David Rientjes wrote: > Now that each mem cgroup on the system has a memory.oom_policy tunable to > specify oom kill selection behavior, remove the needless "groupoom" mount > option that requires (1) the entire system to be forced, perhaps > unnecessarily, perhaps unexpectedly, into a single oom policy that > differs from the traditional per process selection, and (2) a remount to > change. > > Instead of enabling the cgroup aware oom killer with the "groupoom" mount > option, set the mem cgroup subtree's memory.oom_policy to "cgroup". Can we retain the groupoom mount option and use its setting to set the initial value of every memory.oom_policy? That way the mount option remains somewhat useful and we're back-compatible?