Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 26 Jan 2018 04:49:41 +0200
From:   "Michael S. Tsirkin" <mst@redhat.com>
To:     Jason Wang <jasowang@redhat.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Liran Alon <liran.alon@oracle.com>, vkuznets@redhat.com,
        x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] x86/kvm: disable fast MMIO when running nested
Message-ID: <20180126044919-mutt-send-email-mst@kernel.org>
References: <6690c53c-fc99-44ea-9090-6e7438c1bc98@default>
 <20180125141620.GA7663@flask>
 <aaccbf48-ec7d-10bf-9980-8db0ae36b506@redhat.com>
 <2039380511.2539348.1516891762406.JavaMail.zimbra@redhat.com>
 <20180125185431-mutt-send-email-mst@kernel.org>
 <bdc694c8-ee13-f7aa-a551-59380388518e@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bdc694c8-ee13-f7aa-a551-59380388518e@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 26, 2018 at 10:41:58AM +0800, Jason Wang wrote:
> 
> 
> On 2018年01月26日 01:11, Michael S. Tsirkin wrote:
> > On Thu, Jan 25, 2018 at 09:49:22AM -0500, Paolo Bonzini wrote:
> > > > > Michael and Jason, any progress on implementing a fast virtio mechanism
> > > > > that doesn't rely on undefined behavior?
> > > > > 
> > > > > (Encode writing instruction length into last 4 bits of MMIO address,
> > > > >    side-channel say that accesses to the MMIO area always use certain
> > > > >    instruction length, use hypercall, ...)
> > > > > 
> > > > > Thanks.
> > > > No progress from my side. But we can use PIO for virtio 1.0 and it's
> > > > faster than fast MMIO (qemu supports modern pio notification bar, we can
> > > > make it as default). It looks to me that neither encoding nor hypercall
> > > > will work for real hardware virtio device.
> > > Encoding the instruction length would work, the h/w virtio devices would
> > > just ignore it.  But... it is really ugly.
> > > 
> > > Using PIO would be a small step backwards for PCIe.  As long as the device
> > > only needs *one* notification register (either MMIO or PIO) to initialize
> > > successfully, it's okay.  Then if there is no PIO space you'd just fall back
> > > to the slower MMIO notification.
> > > 
> > > Paolo
> > A bigger issue for PIO is it's causing exits for hw devices.
> > 
> > 
> 
> Just to make sure I understand. For exits you mean vmexit? I believe MMIO
> will cause vmexit too.
> 
> Thanks

Not with an assigned device where the PTE is marked as present, it
won't.

-- 
MST