Received: by 10.223.176.46 with SMTP id f43csp230815wra; Thu, 25 Jan 2018 20:57:40 -0800 (PST) X-Google-Smtp-Source: AH8x227XRl5bZBfqNy97NmQG03s7smDoOJ2EVgu0kcnMEhNoqbSzvlydqQkAnwyx442udj7yVUwE X-Received: by 2002:a17:902:4906:: with SMTP id u6-v6mr7788351pld.92.1516942660248; Thu, 25 Jan 2018 20:57:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516942660; cv=none; d=google.com; s=arc-20160816; b=nroVvLh5R92hyrCkZJ1ot54RwBmiGKyzvuNnJ5a0uMbQCqZ2UedRWaWo3nH6JBDehj qIKCx8fX1ilURu6A3yS402xILeIdwzacTI4LPhormlfzTM5Fg/qRxG2g5rCyZ+OZObcP 0CT7rPt1TYczve+xYkptJVNcDsgk/qK2WXF7XGCR6H/KOnHb8n0dPmjT++bvv+v0PBVa 1DhFDBPvqYygAQAnaTls66aSdvaCRQZBlzzc1QR+ehZCQqJucr7a9PHkLZ1rTh1fRMmh nUQOGTtVnvD8MsWhLYEp7FnI6eSGxKeoujTT/lYCdhZiYa+s8pWcrt72Z8d3DNT0v5US +B3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:dlp-filter:cms-type:user-agent :in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:dkim-signature:dkim-filter:arc-authentication-results; bh=hu9v9S2/Nc3Nl8ArWZZaBLydCKuTYHk3xRGY1rtWodM=; b=E9ZPN0Nb+JlniM8bU6Prx9osmueNNj1Z8seY5Q5YQnNRWcC/7/p4HvODPydk7UDHTb m8TvW7CW/Yp8TQ1MeSqxcFhGDDUvwlHxTMTZ7rKr0gin9Pq//B+vOO7Kz3D0bIAU8tUJ mAUzhwYCbP00BF1Bev5LTwxZWFgygYfWbX+ZgfU09X2DW9LDliqlxxSCn//mzUFlnWhK MkM2dk5ujF9ZBd1K/SB3c0xB6JjVxTalMrO2NY6NTcdy1XPkm5Wvus6ZzkRfaO30bZ37 kY8Sk4KZPxXy9NwEkVc3eh3BE/PtqfUvrMUkYTIjW7z6WfbHoCpsAr+GlNLPGKDSgPMF 2O6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=JpoaFSo5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v37-v6si3212009plg.521.2018.01.25.20.57.04; Thu, 25 Jan 2018 20:57:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=JpoaFSo5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751594AbeAZEzW (ORCPT + 99 others); Thu, 25 Jan 2018 23:55:22 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:22591 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbeAZEzU (ORCPT ); Thu, 25 Jan 2018 23:55:20 -0500 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20180126045519epoutp0239e7dbcfa96ac5df34125ab8f9b02183~NQy8g2DNw2953129531epoutp02v; Fri, 26 Jan 2018 04:55:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180126045519epoutp0239e7dbcfa96ac5df34125ab8f9b02183~NQy8g2DNw2953129531epoutp02v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1516942519; bh=hu9v9S2/Nc3Nl8ArWZZaBLydCKuTYHk3xRGY1rtWodM=; h=Date:From:To:Cc:Subject:In-reply-to:References:From; b=JpoaFSo5a8mvTkso41BP3DY5hIE/VBIpnXqutJmeDx6C+4EP3FIx7Hv/Fq1O2isvJ Kh9/knc75Siaz8e/lCDlMOyQFnf6DvjzTxR5sXrrN/I0GWO900EGYJ3g4bMS223dD1 E7jUx+riSrKxUEqMqQ9yoiq0crUdkMyIrylu89Hg= Received: from epsmges2p1.samsung.com (unknown [182.195.40.66]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20180126045518epcas1p28e87641feaef5b659180d69ec44298cb~NQy8Np10e0287202872epcas1p2s; Fri, 26 Jan 2018 04:55:18 +0000 (GMT) Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p1.samsung.com (Symantec Messaging Gateway) with SMTP id F9.4C.04131.6B4BA6A5; Fri, 26 Jan 2018 13:55:18 +0900 (KST) Received: from epsmgms2p2new.samsung.com (unknown [182.195.42.143]) by epcas2p2.samsung.com (KnoxPortal) with ESMTP id 20180126045518epcas2p2ec572373e741b5ea4abe5a6e3237fa22~NQy72UIfo1656216562epcas2p24; Fri, 26 Jan 2018 04:55:18 +0000 (GMT) X-AuditID: b6c32a45-403ff70000001023-a5-5a6ab4b61633 Received: from epmmp2 ( [203.254.227.17]) by epsmgms2p2new.samsung.com (Symantec Messaging Gateway) with SMTP id A8.8E.03890.6B4BA6A5; Fri, 26 Jan 2018 13:55:18 +0900 (KST) Received: from gangnam.samsung ([10.113.77.200]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P35007MTCC61B40@mmp2.samsung.com>; Fri, 26 Jan 2018 13:55:18 +0900 (KST) Date: Fri, 26 Jan 2018 13:55:18 +0900 From: Andi Shyti To: Dmitry Torokhov Cc: Simon Shields , Rob Herring , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] Input: mms114 - mark as direct input device Message-id: <20180126045518.GQ7575@gangnam.samsung> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-disposition: inline In-reply-to: <20180124193804.155654-3-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeT3b2VGbnOalN7WSEyWGmztTtykqWRbDhEZB1CLsMF+cths7 UzT6YGbDhMhIQaaVVgotK1s2NczAkV0wA8XywsJLiYiBrJspUsedBL/93uf5/3ku70Ngkhlh NFFktiObmTFSeIjA401QST2dxTp575hc7b0zD9Tj/l9C9cjzJlz9t7dbpO4cnMT3CzU9Tp9I 43ZdwTVVj9245rt7p1agQxkGxBQgWxwy6y0FRebCTOrI8fyD+alKOS2l09QqKs7MmFAmlZOn lR4uMnJ1qbhSxljChbQMy1JJWRk2S4kdxRksrD2TOk3TChktV8kUCoUsJflMuiKVk5xFhg9N DZh1FSurqKoTVYDbWA0IJiCZAh2fXwrWWUJ2A3ircUcNCOH4N4Crn24KN0RDgy0iPtEBYGvL LOAffgDftbYHVAJyD5xomQDrjJMJsHJyGV/nCDIJdjWuBAwYeQnAJyP9ovVEOJkD2+vaArXF ZDJs++rEeN4Kl298DsQxMhG+H3gEeI6BM2sNAW8wuR/2vHcHOJLcDZsX6gLtQbIdh8OP+gDf dw6sbfThPIfDhdedIp5j4JzryX8N15FnUs+bawH0v/gZxCeS4VxLTRBfOQxWe9c4M8HFxbDa IeFRAx0egldnw2cdLozfylsAOyvr8Vqww7lpHuemeZyb5mkGmAtEIStrKkSswkrLWMbElpgL ZXqLyQ0C97XvUDdoGMrrByQBqC3iivEinUTIlLLlpn4ACYyKEG+VFusk4gKm/DyyWfJtJUbE 9oNU7lOuY9GRegt3rWZ7Pp2SJk9RKhUqpZo7q21ihzZHJyELGTs6h5AV2TZ8QURwdAWI/RMe O/CtXhV78fXgtM0fnR6mWmIfjhKLR+/79PHZXfrF3WkP786smjMvz+/tM9LuqagsYileN3vg 1chJR3b77RP3PuZ60zq2e4d9p3rir67kPciVj9VfaE20G6TM7Goomts1tTj2Rq28Vhb81Kkd dX358epYTKho2jBAxRxhKAFrYOh9mI1l/gFox22MdQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t9jQd1tW7KiDJ7uE7M4vOgFo8XNT99Y LS7vmsNm8X/PDnaLLWduszmweuycdZfdY9OqTjaPlvWb2Dw+b5ILYInisklJzcksSy3St0vg yjg/ZwZzwW/mioaWKewNjPOZuxg5OSQETCTOnVnI3sXIxSEksI5RYsr830wgCSGBT4wStx/4 gdgsAqoStxbeYgSx2QQ0JZpu/2ADsUUE9CW2z/4FFmcWaGaU+HFSHcQWFnCRWDNlGQuIzStg LLHs6SxmiAUnGSVutK9hh0gISvyYfI8FollLYv3O40wQtrTEo78zwGo4BRwkdp7dBGaLCihL LHg1hX0CI/8sJO2zkLTPQtK+gJF5FaNkakFxbnpusVGBUV5quV5xYm5xaV66XnJ+7iZGYOBu O6zVv4Px8ZL4Q4wCHIxKPLw3bmdGCbEmlhVX5h5ilOBgVhLhFdTNihLiTUmsrEotyo8vKs1J LT7EKM3BoiTOy59/LFJIID2xJDU7NbUgtQgmy8TBKdXAqPlSbPqKLb0WUs49l05xz1vgeP+7 O/O0DVH1Fcf7frs3vA1c8yM3X3/elvU7UnbYH3jONOd327HvsQbmmydYZyye9eFsWb6iSH+n dDH7pn9H9p6RzK9yPnB2RdiOFy/Oc+eXLZpaGC7JPsG7e98s1/Zw98KKqyuvHFf6uvnfnLBr yxxnaziGHVFiKc5INNRiLipOBAAZZ+waWAIAAA== X-CMS-MailID: 20180126045518epcas2p2ec572373e741b5ea4abe5a6e3237fa22 X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20180124193814epcas1p22db64829cbf5476abe443b3ef404cd50 X-RootMTR: 20180124193814epcas1p22db64829cbf5476abe443b3ef404cd50 References: <20180124193804.155654-1-dmitry.torokhov@gmail.com> <20180124193804.155654-3-dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Wed, Jan 24, 2018 at 11:38:02AM -0800, Dmitry Torokhov wrote: > mms14 is a touchscreen and thus a direct input device; let's mark it > as such. This also allows us to drop some initialization code as > input_init_mt_slots() will do that for us. > > Also add error handling for input_mt_init_slots(). > > Signed-off-by: Dmitry Torokhov Reviewed-by: Andi Shyti Tested-by: Andi Shyti Thanks, Andi