Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F8B921796
Date:   Fri, 26 Jan 2018 14:40:53 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Will Deacon <will.deacon@arm.com>
Cc:     catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
        linux-arch@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jon Medhurst <tixy@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
        David Howells <dhowells@redhat.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        "Tobin C . Harding" <me@tobin.cc>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 6/8] kprobes/arm64: Fix %p uses in error messages
Message-Id: <20180126144053.82268e050f3fba636f6845df@kernel.org>
In-Reply-To: <20180125164230.GC22963@arm.com>
References: <151685799071.3099.10383062804474021403.stgit@devbox>
        <151685817205.3099.18079175391687728067.stgit@devbox>
        <20180125164230.GC22963@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 25 Jan 2018 16:42:31 +0000
Will Deacon <will.deacon@arm.com> wrote:

> On Thu, Jan 25, 2018 at 02:29:32PM +0900, Masami Hiramatsu wrote:
> > Fix %p uses in error messages by removing it because
> > those are redundant or meaningless.
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> >  arch/arm64/kernel/probes/kprobes.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Acked-by: Will Deacon <will.deacon@arm.com>
> 
> I guess Catalin can just pick this one up via arm64.

OK, thanks!

> 
> Will
> 
> > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c
> > index d849d9804011..34f78d07a068 100644
> > --- a/arch/arm64/kernel/probes/kprobes.c
> > +++ b/arch/arm64/kernel/probes/kprobes.c
> > @@ -275,7 +275,7 @@ static int __kprobes reenter_kprobe(struct kprobe *p,
> >  		break;
> >  	case KPROBE_HIT_SS:
> >  	case KPROBE_REENTER:
> > -		pr_warn("Unrecoverable kprobe detected at %p.\n", p->addr);
> > +		pr_warn("Unrecoverable kprobe detected.\n");
> >  		dump_kprobe(p);
> >  		BUG();
> >  		break;
> > @@ -521,7 +521,7 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs)
> >  		    (struct pt_regs *)kcb->jprobe_saved_regs.sp;
> >  		pr_err("current sp %lx does not match saved sp %lx\n",
> >  		       orig_sp, stack_addr);
> > -		pr_err("Saved registers for jprobe %p\n", jp);
> > +		pr_err("Saved registers for jprobe\n");
> >  		__show_regs(saved_regs);
> >  		pr_err("Current registers\n");
> >  		__show_regs(regs);
> > 


-- 
Masami Hiramatsu <mhiramat@kernel.org>