Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: SoftFail (protection.outlook.com: domain of transitioning
 gmail.com discourages use of 192.88.168.50 as permitted sender)
Date:   Fri, 26 Jan 2018 10:51:16 +0800
From:   Peter Chen <hzpeterchen@gmail.com>
To:     Sebastian Reichel <sebastian.reichel@collabora.co.uk>
CC:     Peter Chen <Peter.Chen@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ian Ray <ian.ray@ge.com>, Nandor Han <nandor.han@ge.com>,
        Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>,
        <kernel@lists.collabora.co.uk>
Subject: Re: [PATCH 2/2] usb: chipidea: imx: Fix ULPI on imx53
Message-ID: <20180126025116.GA6921@b29397-desktop>
References: <20180124171439.10721-1-sebastian.reichel@collabora.co.uk>
 <20180124171439.10721-2-sebastian.reichel@collabora.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20180124171439.10721-2-sebastian.reichel@collabora.co.uk>
User-Agent: Mutt/1.5.24 (2015-08-30)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2018 07:25:30.7474
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d88a05f7-0aef-4ca3-e4d7-08d5648dfb46
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB470
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 24, 2018 at 06:14:39PM +0100, Sebastian Reichel wrote:
> Traditionally, PORTSC should be set before initializing ULPI phys. But
> setting PORTSC before powering on the phy results in a kernel freeze
> on imx53 based GE PPD. As a workaround this initializes the phy early
> in the imx platform code and disables phy power management from the
> core.
> 
> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index de155c80eb70..e431c5aafe35 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -83,6 +83,7 @@ struct ci_hdrc_imx_data {
>  	struct clk *clk;
>  	struct imx_usbmisc_data *usbmisc_data;
>  	bool supports_runtime_pm;
> +	bool override_phy_control;
>  	bool in_lpm;
>  	/* SoC before i.mx6 (except imx23/imx28) needs three clks */
>  	bool need_three_clks;
> @@ -254,6 +255,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>  	int ret;
>  	const struct of_device_id *of_id;
>  	const struct ci_hdrc_imx_platform_flag *imx_platform_flag;
> +	struct device_node *np = pdev->dev.of_node;
>  
>  	of_id = of_match_device(ci_hdrc_imx_dt_ids, &pdev->dev);
>  	if (!of_id)
> @@ -288,6 +290,14 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>  	}
>  
>  	pdata.usb_phy = data->phy;
> +
> +	if (of_device_is_compatible(np, "fsl,imx53-usb") && pdata.usb_phy &&
> +	    of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI) {
> +		pdata.flags |= CI_HDRC_OVERRIDE_PHY_CONTROL;
> +		data->override_phy_control = true;
> +		usb_phy_init(pdata.usb_phy);
> +	}
> +
>  	pdata.flags |= imx_platform_flag->flags;
>  	if (pdata.flags & CI_HDRC_SUPPORTS_RUNTIME_PM)
>  		data->supports_runtime_pm = true;
> @@ -341,6 +351,8 @@ static int ci_hdrc_imx_remove(struct platform_device *pdev)
>  		pm_runtime_put_noidle(&pdev->dev);
>  	}
>  	ci_hdrc_remove_device(data->ci_pdev);
> +	if (data->override_phy_control)
> +		usb_phy_shutdown(data->phy);
>  	imx_disable_unprepare_clks(&pdev->dev);
>  
>  	return 0;
> -- 

Applied both, thanks.

-- 

Best Regards,
Peter Chen