Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 26 Jan 2018 09:48:39 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Meghana Madhyastha <meghana.madhyastha@gmail.com>
Cc:     Daniel Thompson <daniel.thompson@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Noralf =?iso-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper
 in backlight.c
Message-ID: <20180126094839.iksjiw4xj2n62yzn@dell>
References: <cover.1516810725.git.meghana.madhyastha@gmail.com>
 <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 24 Jan 2018, Meghana Madhyastha wrote:

> Add of_find_backlight, a helper function which is a generic version
> of tinydrm_of_find_backlight that can be used by other drivers to avoid
> repetition of code and simplify things.
> 
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
> Reviewed-by: Sean Paul<seanpaul@chromium.org>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>

Nit: These should be in chronological order.

> ---
>  drivers/video/backlight/backlight.c | 43 +++++++++++++++++++++++++++++++++++++
>  include/linux/backlight.h           | 19 ++++++++++++++++
>  2 files changed, 62 insertions(+)

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog