Received: by 10.223.176.46 with SMTP id f43csp608566wra; Fri, 26 Jan 2018 04:09:55 -0800 (PST) X-Google-Smtp-Source: AH8x225C5yJM9A51+MlABx8jA84J2FBH1VZ/G/2IFs460s0ODJYYASzb9seA+lo7lsD+KF9+bsk1 X-Received: by 2002:a17:902:658f:: with SMTP id c15-v6mr14022954plk.412.1516968595405; Fri, 26 Jan 2018 04:09:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516968595; cv=none; d=google.com; s=arc-20160816; b=bvH/c1Wexgg7vZ8hfV95FvbgNAZcY5MqJPnP4B//KvnyffE0HNSHpQ0muzZKqwdX3B egTV/x2t7sBUjS6KuAc1/3qpbsNhWjWZFiZD0LMH9G8H9XqAnHb9aQLuZ+Vz8q+ZCFQG dd0XK3TXL6NwArND0SuyTkXbrg3JKrmz7fEPo6W6iFkLx3Aui78t+BIIKPymHGz+Ap7w s5NjqmCBT3XSk8b6j1J3dqTbpcSvFdL6sMjUZyMioMAXMWdqS5MXS3jRv07AzfBZSB9y WvrkXC2rj1E9tX77cRwqXvaeGm22pHkMlVPQh45FXdo8Xo1ZssKmVN0kblhMRhxR6ibg xZ/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=RugXaLkvFnEOPUagvOY4Q7tG1fwHyVC6dLwr0wXRrW8=; b=c1T2V2U6W/kZAcoizpJDoJ40aVzPv0VdZz5+FMQR7d5yJ5Z82i7oIRvtuRvNSkvN7w FKL+N5kOwfed8dFpe/0g5Wur73mi24Ekku8V5eA55ETEbuTUFXFAGDrEElrFKGHVlkim iMobdDgco2UUhC96L4aqXIpBVqTDQVaOLJc0V2Mc18/Mr2j5IlMjl3GpcYpslJDjREh9 LXFgdh8K48sXuulRw6cPkfMTdfYjbAuFppl9IPdP0utMzGczVgri8C7ke38hoKtgc5Ji VhQlQN6aJVxOWvwzJiN1AFVCRVz1p5BZRl+BqxYmUCScjvukhXuPSSF6qFgbLEvX6pJY Ziyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f25si2916725pge.163.2018.01.26.04.09.40; Fri, 26 Jan 2018 04:09:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751607AbeAZMJT (ORCPT + 99 others); Fri, 26 Jan 2018 07:09:19 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:55001 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751444AbeAZMJS (ORCPT ); Fri, 26 Jan 2018 07:09:18 -0500 X-UUID: b062c43c51d048f890565825a127661d-20180126 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 2084170053; Fri, 26 Jan 2018 20:09:13 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 26 Jan 2018 20:09:12 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Fri, 26 Jan 2018 20:09:12 +0800 From: To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton CC: , , , , Miles Chen Subject: [PATCH] slub: remove obsolete comments of put_cpu_partial() Date: Fri, 26 Jan 2018 20:09:10 +0800 Message-ID: <1516968550-1520-1-git-send-email-miles.chen@mediatek.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miles Chen The commit d6e0b7fa1186 ("slub: make dead caches discard free slabs immediately") makes put_cpu_partial() run with preemption disabled and interrupts disabled when calling unfreeze_partials(). The comment: "put_cpu_partial() is done without interrupts disabled and without preemption disabled" looks obsolete, so remove it. Signed-off-by: Miles Chen --- mm/slub.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index cfd56e5a35fb..70447d39de90 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2220,9 +2220,7 @@ static void unfreeze_partials(struct kmem_cache *s, /* * Put a page that was just frozen (in __slab_free) into a partial page - * slot if available. This is done without interrupts disabled and without - * preemption disabled. The cmpxchg is racy and may put the partial page - * onto a random cpus partial slot. + * slot if available. * * If we did not find a slot then simply move all the partials to the * per node partial list. -- 2.12.5