Received: by 10.223.176.46 with SMTP id f43csp690094wra; Fri, 26 Jan 2018 05:27:10 -0800 (PST) X-Google-Smtp-Source: AH8x2241Iq6DSRssIpMob9sX8LxrFhf/gJfCccyjgCY1XrbPj6imt5uZUYZpE951BOYE2kymsIfz X-Received: by 10.98.35.14 with SMTP id j14mr19254372pfj.62.1516973229914; Fri, 26 Jan 2018 05:27:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516973229; cv=none; d=google.com; s=arc-20160816; b=cMKfHLmyjEtdC2u9ukXzJfewgol1O+qaFsFubpMj9M04wXHXHNKmqco3gk/bgwSy7A w7yk6uhZ8NZlurOSkqmOtQeKOxqua4KyrhiltezXsXtL+xIo8wwC0aNtBwDbmZo09kqY +fYMx/TPf3VjyIGHjAvDWhiFPn/JCZZatREDH2bexojckdhK0nMD6S5m4eoXdrMqoODq o4iAb22MgwrGOVCnyT6IDeYC7LYN0qIqwJzcBCuZKwjuaHXPMm6zNjLtWgcgE7IPY8lF 8vKg74uknSJe9U/InLczv+/yTgd3DAg4bjzko/IOzeV2NJ0mfQJKj8J5EmObe2dhj0T8 6Evg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-transfert-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=8GS4kwyq+4BZIm/K5fzUcJxHFJHs5ja9/bP+hiCbBsQ=; b=RSOEhURfme3NMPjIBYrld9jXzmhTi/XVH7RFX4B071Ws8ZfbEpzHGFh6Qv1SRb0v5E v9GeG690L5WzivY0+YFmSJU8UZNEBRLNdazDY0R4jhKZQ/LAvXz0d+ki1yDAhl+8lLex oRv5ccmCagfrVm57cmsofsNunil+bpY7hzKDdZjw8kqIQq82MiugClr/Kfh/TyJ6IzzS ttXVOS/MEiiPqptNdp+omF6a3AYOBsy6kWBIimyOBsRENHZtpDh51URh51/Q6JlgSqo6 pWOW+cBmo0Mr9wayCPfgU0fBQLLCJtbpKVqagdV/UjfpfcPfjFSMev7kOG+pnp1bFrxD MMIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12-v6si3721288plt.638.2018.01.26.05.26.55; Fri, 26 Jan 2018 05:27:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbeAZNRp (ORCPT + 99 others); Fri, 26 Jan 2018 08:17:45 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:34388 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbeAZNRm (ORCPT ); Fri, 26 Jan 2018 08:17:42 -0500 Received: from localhost.localdomain (unknown [IPv6:2a01:e35:8a7e:4790:a8d7:ca4:7b4f:7f87]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tescande) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 88D8E27470C; Fri, 26 Jan 2018 13:17:40 +0000 (GMT) From: Thierry Escande To: Archit Taneja , Inki Dae , Thierry Reding , Sandy Huang , Sean Paul , David Airlie , Tomasz Figa Cc: Haixia Shi , =?UTF-8?q?=C3=98rjan=20Eide?= , Zain Wang , Yakir Yang , Lin Huang , Douglas Anderson , Mark Yao , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH v2 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind Date: Fri, 26 Jan 2018 14:16:32 +0100 Message-Id: <20180126131710.7622-6-thierry.escande@collabora.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180126131710.7622-1-thierry.escande@collabora.com> References: <20180126131710.7622-1-thierry.escande@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset = "utf-8" Content-Transfert-Encoding: 8bit Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zain wang The bridge does not need to be powered in analogix_dp_bind(), so remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() as well as their power-off counterparts. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Caesar Wang [the patch originally just removed the power_on portion, seanpaul removed the power off code as well as improved the commit message] Signed-off-by: Sean Paul Signed-off-by: Thierry Escande --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index cb5e18d6ba04..1477ea9ba85d 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1382,11 +1382,6 @@ analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, pm_runtime_enable(dev); - pm_runtime_get_sync(dev); - phy_power_on(dp->phy); - - analogix_dp_init_dp(dp); - ret = devm_request_threaded_irq(&pdev->dev, dp->irq, analogix_dp_hardirq, analogix_dp_irq_thread, @@ -1414,15 +1409,10 @@ analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, goto err_disable_pm_runtime; } - phy_power_off(dp->phy); - pm_runtime_put(dev); - return dp; err_disable_pm_runtime: - phy_power_off(dp->phy); - pm_runtime_put(dev); pm_runtime_disable(dev); return ERR_PTR(ret); -- 2.14.1