Received: by 10.223.176.46 with SMTP id f43csp872877wra; Fri, 26 Jan 2018 08:12:39 -0800 (PST) X-Google-Smtp-Source: AH8x2257E5Yr1e2ASJNEzqA6FvLJuJywEiVSvZHounTHjHdmzrhm3ItWa1a4QNXT1IZV/jBfC5z0 X-Received: by 2002:a17:902:40e:: with SMTP id 14-v6mr14610004ple.64.1516983159275; Fri, 26 Jan 2018 08:12:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516983159; cv=none; d=google.com; s=arc-20160816; b=NSKCtLUa5LyyjLuXylZM+Xf0u/HTUmEBfT8ZKOj6mA2fIfPAKYVLGRD7nkbxbVNVxm 8gAeK6tE1uGTFzHrRSH7KWWY2g1tMQperI5yGpu2Rl3akz54eVBN22/Jj5qIZCNLcZkn rrmDsVyn5yXEe/hlucsb0aHuIKWBtbSYkn3swOadkbLH3neRnxHHovrVr0eAuL/kDxXn lgA4zoBeNidP3UZPRjgWaHySRFwa8rya1R7g2b/0uhHdbe1p+JBVEHd7iDkCU6eULX8U uCbE3yDt2uBaDCeRVFcCI9Muy286m+THSz88Hl0FfVmjjsBcHQkjXuhjOnga7uJC1Bmw DNrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=VMWs8414py1lHct6yZeSBjm8BsF2wLLewPTqeqm2+Nc=; b=VHNa73/+8riP+EU35fmFKEmXPZfb5bNfydItNvgJ8oSLGWM/jOsZ4VoUaIBYqqd4Vi ulXvrkq+0umnzsg/JlC38imfRZDXGyalSJlFegEcK4yhCrmNF6s3ND8rNAfglGW8kN0T lHTvvb0dNQ3zswMh7I5NchD76n8x1G6StyOBJabu3vDBYhJVp9dWAILekgnXUm6uAbpF 98U+3hrCi7ySl5LSfipwrSRShhlHVtASp9QnKmavYW4hLoKdMUID5thD49r97Zz+D4jG TIixMnY9FENAxQ9JqhfIfk6QZWjdoTBUdg0PmqER/cjIO7K30DWzOit90pkw+6rxToNI 4QOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h12si3116773pgp.65.2018.01.26.08.12.24; Fri, 26 Jan 2018 08:12:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753888AbeAZQKR (ORCPT + 99 others); Fri, 26 Jan 2018 11:10:17 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47476 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753836AbeAZQKQ (ORCPT ); Fri, 26 Jan 2018 11:10:16 -0500 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0DE0D109164E9; Fri, 26 Jan 2018 08:10:15 -0800 (PST) Date: Fri, 26 Jan 2018 11:10:15 -0500 (EST) Message-Id: <20180126.111015.455737320290348169.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: viro@ZenIV.linux.org.uk, 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] atm: firestream: Replace GFP_ATOMIC with GFP_KERNEL in fs_send From: David Miller In-Reply-To: References: <1516953627-30983-1-git-send-email-baijiaju1990@gmail.com> <20180126120522.GX13338@ZenIV.linux.org.uk> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 26 Jan 2018 08:10:16 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Fri, 26 Jan 2018 21:56:32 +0800 > My tool did not handle this situation of passing function pointer, and > I will improve the tool... Never automate these kinds of changes. Actually audit the change fully _yourself_ as a human after the tool indicates a possibility to you. This is why most of your changes have bugs, you rely on the tool too much.