Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 26 Jan 2018 16:47:47 +0000
From:   Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To:     Yves-Alexis Perez <corsac@debian.org>
Cc:     David Woodhouse <dwmw@amazon.co.uk>, arjan@linux.intel.com,
        tglx@linutronix.de, karahmed@amazon.de, x86@kernel.org,
        linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com,
        bp@alien8.de, peterz@infradead.org, pbonzini@redhat.com,
        ak@linux.intel.com, torvalds@linux-foundation.org,
        gregkh@linux-foundation.org, dave.hansen@intel.com
Subject: Re: [PATCH v3 5/6] x86/pti: Do not enable PTI on processors which
 are not vulnerable to Meltdown
Message-ID: <20180126164747.795831ab@alans-desktop>
In-Reply-To: <1516968886.19619.7.camel@debian.org>
References: <1516813025-10794-1-git-send-email-dwmw@amazon.co.uk>
        <1516813025-10794-6-git-send-email-dwmw@amazon.co.uk>
        <1516968886.19619.7.camel@debian.org>
Organization: Intel Corporation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 26 Jan 2018 13:14:46 +0100
Yves-Alexis Perez <corsac@debian.org> wrote:

> On Wed, 2018-01-24 at 16:57 +0000, David Woodhouse wrote:
> > Some old Atoms, anything in family 5 or 4, and newer CPUs when they advertise
> > the IA32_ARCH_CAPABILITIES MSR and it has the RDCL_NO bit set, are not vulnerable.
> > 
> > Roll the AMD exemption into the x86_match_cpu() table too.
> > 
> > Based on suggestions from Dave Hansen and Alan Cox.  
> 
> Hi David,
> 
> I know we'll still be able to manually enable PTI with a command line option,
> but it's also a hardening feature which has the nice side effect of emulating
> SMEP on CPU which don't support it (e.g the Atom boxes above).
> 
> Couldn't we keep the “default on”? Or maybe on boxes which also have CPID (in
> order to limit the performance cost)?

For the old atom processors you really don't want the extra cost as a
default. These are older much slower devices and don't have PCID.

Alan